An error occurred fetching the project authors.
- 06 Jul, 2017 12 commits
-
-
Timothy Andrew authored
- Don't use `request.env['omniauth.params']` if it isn't present. - Remove the `saml` section from the `gitlab.yml` test section. Some tests depend on this section not being initially present, so it can be overridden in the test. This MR doesn't add any tests for SAML, so we didn't really need this in the first place anyway. - Clean up the test -> omniauth section of `gitlab.yml`
-
Timothy Andrew authored
- Disable an ESLint check rather than work around it (by converting `OAuthRememberMe` from a regular class to a static class. - Scope `$` calls inside `OAuthRememberMe`
-
Timothy Andrew authored
- Change double quotes to single quotes. - Why is `OmniAuth.config.full_host` being reassigned in the integration test? - Use `map` over `map!` to avoid `dup` in the `gitlab:info` rake task - Other minor changes
-
Timothy Andrew authored
- The test for `rake gitlab:env:info` executed the rake task, which mutated the list of omniauth providers, breaking subsequent tests relying on this list. - I've changed the rake task to duplicate the providers list before modifying it.
-
Timothy Andrew authored
-
Timothy Andrew authored
-
Timothy Andrew authored
- I tried to get this to work by stubbing out portions of the config within the test. This didn't work as expected because Devise/Omniauth loaded before the stub could run, and the stubbed config was ignored. - I attempted to fix this by reloading Devise/Omniauth after stubbing the config. This successfully got Devise to load the stubbed providers, but failed while trying to access a route such as `user_gitlab_omniauth_authorize_path`. - I spent a while trying to figure this out (even trying `Rails.application.reload_routes!`), but nothing seemed to work. - I settled for adding this config directly to `gitlab.yml` rather than go down this path any further.
-
Timothy Andrew authored
- Added saml, authentiq, cas3, and auth0 - Crowd seems to be a special case that will be handled separately.
-
Timothy Andrew authored
-
Timothy Andrew authored
-
Timothy Andrew authored
- There was previously a test for `saml` login in `login_spec`, but this didn't seem to be passing. A lot of things didn't seem right here, and I suspect that this test hasn't been running. I'll investigate this further. - It took almost a whole working day to figure out this line: OmniAuth.config.full_host = ->(request) { request['REQUEST_URI'].sub(request['REQUEST_PATH'], '') } As always, it's obvious in retrospect, but it took some digging to figure out tests were failing and returning 404s during the callback phase. - Test all OAuth providers - github, twitter, bitbucket, gitlab, google, and facebook
-
Timothy Andrew authored
- Pass a `remember_me` query parameter along with the initial OAuth request, and pick this parameter up during the omniauth callback from request.env['omniauth.params']`. - For 2FA-based login, copy the `remember_me` param from `omniauth.params` to `params`, which the 2FA process will pick up. - For non-2FA-based login, simply call the `remember_me` devise method to set the session cookie.
-
- 03 Jul, 2017 13 commits
-
-
Rémy Coutable authored
Fixed typo in gitlab_flow.md See merge request !12561
-
Rémy Coutable authored
Replaces 'dashboard/new-project.feature' spinach with rspec See merge request !12550
-
Sean McGivern authored
Eagerly create a milestone that is used in a feature spec Closes #34609 See merge request !12604
-
Rémy Coutable authored
Fix curl example paths (missing the 'files' segment) See merge request !12588
-
Sean McGivern authored
Use correct milestones for filtering on Group Issues Closes #34116 See merge request !12374
-
Rémy Coutable authored
Signed-off-by: Rémy Coutable <remy@rymai.me>
-
Kamil Trzciński authored
Remove unnecessary pull command from codeclimate job See merge request !12583
-
Phil Hughes authored
Adjust readme repo width See merge request !12585
-
Dimitrie Hoekstra authored
-
Sean McGivern authored
Make clear that Go 1.8 is required since GitLab 9.2 Closes #34525 See merge request !12564
-
Sean McGivern authored
Fix performance bar specs See merge request !12225
-
Phil Hughes authored
Merge branch '34097-issue-board-remove-from-board-button-when-viewing-an-issue-gives-js-error-and-fails' into 'master' Resolve "Issue Board -> "Remove from board" button when viewing an issue gives js error and fails" Closes #34097 See merge request !12430
-
Luke "Jared" Bennett authored
-
- 02 Jul, 2017 4 commits
-
-
Tim Zallmann authored
Make issuable sidebar setSidebarHeight more efficient See merge request !12252
-
Grzegorz Bizon authored
Make entrypoint and command keys to be array of strings See merge request !12536
-
Tomasz Maczukin authored
-
Tomasz Maczukin authored
-
- 30 Jun, 2017 11 commits
-
-
Jacob Schatz authored
Enable webpack code splitting Closes #32989 See merge request !12032
-
Annabel Dunstone Gray authored
Add issuable-list class to shared mr/issue lists to fix new responsive layout See merge request !12591
-
Clement Ho authored
Remove empty afterEach() from issue_show app_spec.js See merge request !12577
-
Phil Hughes authored
Restore timeago translations in renderTimeago. See merge request !12590
-
tauriedavis authored
-
Annabel Dunstone Gray authored
New navigation breadcrumbs Closes #34029 See merge request !12346
-
Phil Hughes authored
-
Bryce Johnson authored
-
Phil Hughes authored
Remove initTimeagoTimeout and let timeago.js update timeagos internally. Closes #34340 See merge request !12468
-
Joe Marty authored
-
Rémy Coutable authored
Speed up issue counting for a project Closes #33913 See merge request !12457
-