- 15 Jun, 2021 40 commits
-
-
Mark Florian authored
Previously, the staleness message shown for the security report on an MR was determined using this (pseudo-code) logic: if target_branch_security_report_is_older_than_7_days: if mr_branch_diverged_from_target_branch: render "Update your branch with latest changes from target branch" else: render "Run a new pipeline for target branch" This change un-nests the logic so that each condition (whether the target branch's latest security report is older than 7 days; whether the MR branch has diverged from the target branch) alone produces the relevant warning message. That is, the logic has changed to this: if mr_branch_diverged_from_target_branch: render "Update your branch with latest changes from target branch" else if target_branch_security_report_is_older_than_7_days: render "Run a new pipeline for target branch" This means that the mr_branch_diverged_from_target_branch warning will now almost always be shown for highly active projects. This is because the security report for an MR is based on the comparison of the security report of the latest HEAD of the target branch and the HEAD of the MR branch, and therefore won't give entirely correct results if the two have diverged. The target_branch_security_report_is_older_than_7_days message will continue to be shown with the same frequency. This change also aligns the implementation with the documented[doc] behaviour. While this is now more correct, it may be a bit more noisy than the previous behaviour. There is future work planned[1] to use the merge base for the comparison instead, which would improve this further. Finally, this also: - refactors the component tests to conform a bit more to our current standards; - replaces some Bootstrap utility classes with GitLab UI classess. Addresses part of https://gitlab.com/gitlab-org/gitlab/-/issues/267504. [1]: https://gitlab.com/gitlab-org/gitlab/-/issues/295167 [doc]: https://docs.gitlab.com/13.12/ee/user/application_security/index.html#outdated-security-reports Changelog: changed EE: true
-
Max Woolf authored
Remove CI_PROJECT_CONFIG_PATH variable See merge request gitlab-org/gitlab!61977
-
Jacques Erasmus authored
Add Replace button to Blob Header See merge request gitlab-org/gitlab!62880
-
Max Woolf authored
Adds more identifiers to Seat Link See merge request gitlab-org/gitlab!63909
-
Sanad Liaquat authored
E2E: Remove subgroup validation for bulk import See merge request gitlab-org/gitlab!63972
-
David Fernandez authored
Fix Helm version regexp to match unprefixed semver too See merge request gitlab-org/gitlab!63967
-
Natalia Tepluhina authored
Progressively load releases on the Releases page See merge request gitlab-org/gitlab!63528
-
Nathan Friend authored
-
Natalia Tepluhina authored
Split out the datetime utilities See merge request gitlab-org/gitlab!53723
-
Tim Zallmann authored
-
Kati Paizee authored
Improve the Snowplow guide/docs introduction See merge request gitlab-org/gitlab!64056
-
Vitali Tatarintev authored
Add mutation to edit escalation policies See merge request gitlab-org/gitlab!62533
-
Sarah Yasonik authored
-
James Lopez authored
Return new infrastructure registry path for package details See merge request gitlab-org/gitlab!63685
-
GitLab Release Tools Bot authored
-
Achilleas Pipinellis authored
Remove references to PG 11 and Repmgr from Geo docs See merge request gitlab-org/gitlab!63820
-
Achilleas Pipinellis authored
Nav menu changes in misc docs See merge request gitlab-org/gitlab!63925
-
Matthias Käppler authored
Remove `notification_setting_recipient_refactor` feature flag [RUN ALL RSPEC] [RUN AS-IF-FOSS] See merge request gitlab-org/gitlab!63827
-
Heinrich Lee Yu authored
Move GraphQL docs renderer to tooling See merge request gitlab-org/gitlab!63848
-
Heinrich Lee Yu authored
This removes the early return that we have on these classes to prevent eager loading in production. This also prepares us for the switch to Zeitwerk because it complains that the file does not define a class in production.
-
David O'Regan authored
Update markup in _service_templates_deprecated_alert.html.haml file See merge request gitlab-org/gitlab!63159
-
Albert Salim authored
Move reviewer roulette table above and improve text See merge request gitlab-org/gitlab!62360
-
Sanad Liaquat authored
-
Mark Lapierre authored
Refactor Github importer e2e spec See merge request gitlab-org/gitlab!63402
-
Andrejs Cunskis authored
-
David Kim authored
Changelog: other
-
Vitaly Slobodin authored
Update Styling of MR-Widget See merge request gitlab-org/gitlab!63736
-
Thong Kuah authored
Upgrade DAST to version 2 See merge request gitlab-org/gitlab!62597
-
Avielle Wolfe authored
DAST templates have been bumped to depend on DAST version 2. This is a breaking change from DAST version 1. Changelog: changed MR: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/62597 EE: true
-
Kushal Pandya authored
Show the bytes for file changes when the file is not diffable See merge request gitlab-org/gitlab!62445
-
David Kim authored
Avoid idling in transaction while saving project export object See merge request gitlab-org/gitlab!63350
-
Russell Dickenson authored
Epic boards docs update for 14.0 release See merge request gitlab-org/gitlab!62434
-
Florie Guibert authored
-
Mathieu Parent authored
Changelog: changed
-
Thong Kuah authored
Resolve "Ensure diff collection limits are configurable" [RUN ALL RSPEC] [RUN AS-IF-FOSS] See merge request gitlab-org/gitlab!56722
-
Marc Shaw authored
Issue: gitlab.com/gitlab-org/gitlab/-/issues/31063 Mr: gitlab.com/gitlab-org/gitlab/-/merge_requests/56722 Changelog: added
-
Axel García authored
-
Kerri Miller authored
Fix license compliance when no new denied licenses See merge request gitlab-org/gitlab!62343
-
Igor Frenkel authored
-
Douglas Barbosa Alexandre authored
Add networkPolicies to GraphQL API for project See merge request gitlab-org/gitlab!63696
-