- 28 Oct, 2016 3 commits
-
-
Rémy Coutable authored
This is because group owners have their `:admin_group_member` permission removed when the group is LDAP synced, thus ending in an early return at `return member unless can_update_member?(current_user, member)` in `Member.add_user`, leading to new LDAP users not being created. This make this change while still being able to approve access requests during a LDAP sync, `Members::ApproveAccessRequestService` has been changed (in CE) to accept a `:force` option that bypass permission check (since the permission is removed for owners of LDAP-synced groups). This option is thus set to `ldap` in `Member.add_user`. Signed-off-by: Rémy Coutable <remy@rymai.me>
-
Rémy Coutable authored
This param allows to bypass permission check. It is useful for LDAP-sync where even owners don't have the :admin_group_member permission. See https://gitlab.com/gitlab-org/gitlab-ee/blob/6081c37123abae4570f78831b33c2f45f92c2765/app/policies/group_policy.rb#L38 and https://gitlab.com/gitlab-org/gitlab-ee/issues/1159Signed-off-by: Rémy Coutable <remy@rymai.me>
-
Valery Sizov authored
CE upstream See merge request !812
-
- 27 Oct, 2016 8 commits
-
-
Alfredo Sumaran authored
-
Sean McGivern authored
Proper ES version check See merge request !827
-
Valery Sizov authored
-
Sean McGivern authored
ES documentation: Fix rake command Closes https://gitlab.com/gitlab-org/gitlab-ee/issues/1169 See merge request !825
-
Sean McGivern authored
The gitlab:check rake task checks ES version according to requirements See merge request !824
-
Valery Sizov authored
-
Valery Sizov authored
-
Valery Sizov authored
-
- 26 Oct, 2016 6 commits
-
-
Achilleas Pipinellis authored
Improve Geo documentation for 8.13 This merge-request was initiated after feedback from costumers about our documentation. It's a bunch of small fixes to add extra troubleshooting and improve the understanding of the required steps. # Documentation changes/added: - [x] Add "Host key verification" troubleshooting doc for Geo - [x] Update rsync instructions to preserve repository user/group ownership - [x] Communicate better the setup steps and the correct order they must happen cc @dewetblomerus @marin See merge request !766
-
Achilleas Pipinellis authored
Add a trigger variable to docs trigger job From https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/7089 See merge request !819
-
Achilleas Pipinellis authored
-
Rémy Coutable authored
Signed-off-by: Rémy Coutable <remy@rymai.me>
-
Timothy Andrew authored
We have separate methods to delete redundant CE/EE access levels. So, either `delete_redundant_access_levels` or `delete_redundant_ee_access_levels` needs to be called, not both (as was the case here).
-
Timothy Andrew authored
Lines were duplicated.
-
- 25 Oct, 2016 22 commits
-
-
Valery Sizov authored
-
Rémy Coutable authored
Fix branch protection API - EE-specific (spec) changes related to gitlab-org/gitlab-ce!6215. - Related to gitlab-org/gitlab-ce#21513. See merge request !718
-
Sean McGivern authored
Hides multiple board actions if user doesnt have permissions Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/23678 See merge request !816
-
James Lopez authored
As we now expire all caches and then call build_cache, we have to mock this in the spec as we are never creating an actual repo in the filesystem.
-
Douglas Barbosa Alexandre authored
-
Douglas Barbosa Alexandre authored
-
Phil Hughes authored
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/23678
-
Valery Sizov authored
-
Sean McGivern authored
Fix for Elasticsearch::Transport::Transport::Errors::BadRequest: [400] Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/21036 See merge request !818
-
Valery Sizov authored
-
Valery Sizov authored
-
Valery Sizov authored
-
Valery Sizov authored
-
Achilleas Pipinellis authored
-
Achilleas Pipinellis authored
-
Achilleas Pipinellis authored
-
Stan Hu authored
-
Stan Hu authored
-
Stan Hu authored
-
Grzegorz Bizon authored
-
Stan Hu authored
-
Stan Hu authored
If you attempt to move an issue from one project to another and leave labels blank, LabelsFinder would assign all labels in the new project to that issue. The issue is that :title is passed along to the Finder, but since it appears empty no filtering is done. As a result, all labels in the group are returned. This fix handles that case. Closes #23668
-
- 24 Oct, 2016 1 commit
-
-
Annabel Dunstone Gray authored
Enable SpaceAfterVariableColon in scss-lint ## What does this MR do? Enables `SpaceAfterVariableColon` in `.scss-lint.yml` ## Are there points in the code the reviewer needs to double check? None ## Why was this MR needed? Improve SCSS maintainability and consistency ## Screenshots (if relevant) None ## Does this MR meet the acceptance criteria? - Tests - [x] All builds are passing - [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html) - [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides) - [x] Branch has no merge conflicts with `master` (if it does - rebase it please) - [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits) ## What are the relevant issue numbers? #23485 See merge request !7080
-