An error occurred fetching the project authors.
- 09 Dec, 2019 1 commit
-
-
GitLab Bot authored
-
- 04 Dec, 2019 1 commit
-
-
GitLab Bot authored
-
- 20 Nov, 2019 1 commit
-
-
GitLab Bot authored
-
- 29 Oct, 2019 1 commit
-
-
GitLab Bot authored
-
- 24 Oct, 2019 1 commit
-
-
GitLab Bot authored
-
- 23 Oct, 2019 1 commit
-
-
GitLab Bot authored
-
- 10 Oct, 2019 2 commits
-
-
GitLab Bot authored
-
GitLab Bot authored
-
- 09 Oct, 2019 1 commit
-
-
GitLab Bot authored
-
- 24 Sep, 2019 1 commit
-
-
GitLab Bot authored
-
- 03 Sep, 2019 1 commit
-
-
Krasimir Angelov authored
so that we can use API::Internal namespace. Related to https://gitlab.com/gitlab-org/gitlab-ce/issues/61927.
-
- 28 Aug, 2019 1 commit
-
-
Michael Kozono authored
Instead of sending varied data to Gitaly, and making Gitaly construct various messages, build the messages first and have Gitaly print either basic messages or alert messages, in the order they come. Depends on https://gitlab.com/gitlab-org/gitaly/merge_requests/1410
-
- 09 Jul, 2019 1 commit
-
-
Bob Van Landuyt authored
Some of the specs were using namespace names instead of paths for building URLS. This would fail since we now build a namespace with a user's name instead of a user's username.
-
- 17 May, 2019 1 commit
-
-
Luke Duncalfe authored
`Gitlab::QueryLimiting.whitelist` has been moved from being inside the feature flag conditional check to the `process_mr_push_options` `Api::Internal` helper. https://gitlab.com/gitlab-org/gitlab-ce/issues/60250
-
- 03 May, 2019 1 commit
-
-
Stan Hu authored
When creating a merge request for push options, there may be over 100 queries that are run to create a merge request. Even after we reduce the number of queries by disabling the Sidekiq jobs, it appears we still hover near this limit. Closes https://gitlab.com/gitlab-org/gitlab-ee/issues/11450
-
- 16 Apr, 2019 1 commit
-
-
Luke Duncalfe authored
The intention of this test is to ensure that the service class MergeRequests::PushOptionsHandlerService does not run when the :mr_push_options feature flag is disabled. This test was passing, however was not testing what it was supposed to be! For one, setting Feature.disable(:feature) in the test does not disable the feature, as rspec config in spec_helper stubs Feature to make all features enabled: https://gitlab.com/gitlab-org/gitlab-ce/commit/3ee48e422defaedd69946c607bd8d3672e510375 So the feature was still enabled in the test. But this test wasn't failing because unfortunately I had put: ``` expect(MergeRequests::PushOptionsHandlerService).to receive(:new) ``` instead of not_to! This meant that the `.new` method was being stubbed, so the service class did not create a MergeRequest, which satisfied the second expectation. ``` expect(MergeRequests::PushOptionsHandlerService).to receive(:new) ```
-
- 08 Apr, 2019 5 commits
-
-
Luke Duncalfe authored
Exceptions are no longer raised, instead all errors encountered are added to the errors property. MergeRequests::BuildService is used to generate attributes of a new merge request. Code moved from Api::Internal to Api::Helpers::InternalHelpers.
-
Luke Duncalfe authored
Previously the raw push option Array was sent to Pipeline::Chain::Skip. This commit updates this class (and the chain of classes that pass the push option parameters from the API internal `post_receive` endpoint to that class) to treat push options as a Hash of options parsed by GitLab::PushOptions. The GitLab::PushOptions class takes options like this: -o ci.skip -o merge_request.create -o merge_request.target=branch and turns them into a Hash like this: { ci: { skip: true }, merge_request: { create: true, target: 'branch' } } This now how Pipeline::Chain::Skip is determining if the `ci.skip` push option was used.
-
Luke Duncalfe authored
-
Luke Duncalfe authored
To create a new merge request: git push -u origin -o merge_request.create To create a new merge request setting target branch: git push -u origin -o merge_request.create \ -o merge_request.target=123 To update an existing merge request with a new target branch: git push -u origin -o merge_request.target=123 A new Gitlab::PushOptions class handles parsing and validating the push options array. This can be the start of the standard of GitLab accepting push options that follow namespacing rules. Rules are discussed in issue https://gitlab.com/gitlab-org/gitlab-ce/issues/43263. E.g. these push options: -o merge_request.create -o merge_request.target=123 Become parsed as: { merge_request: { create: true, target: '123', } } And are fetched with the class via: push_options.get(:merge_request) push_options.get(:merge_request, :create) push_options.get(:merge_request, :target) A new MergeRequests::PushOptionsHandlerService takes the `merge_request` namespaced push options and handles creating and updating merge requests. Any errors encountered are passed to the existing `output` Hash in Api::Internal's `post_receive` endpoint, and passed to gitlab-shell where they're output to the user. Issue https://gitlab.com/gitlab-org/gitlab-ce/issues/43263
- 05 Apr, 2019 1 commit
-
-
Bob Van Landuyt authored
This makes sure that we always have a repository type when trying to parse a repository from a path. This is needed because sometimes we want to perform access checks as if the project already existed, for example when creating a project on push. Before this we were only doing that when accessing git over http, this makes sure it also works correctly when accessing git over SSH
-
- 04 Apr, 2019 1 commit
-
-
Ash McKenzie authored
Currently a no-op for CE
-
- 26 Mar, 2019 1 commit
-
-
Bob Van Landuyt authored
This changes the repository type from a binary `wiki?` to a type. So we can have more than 2 repository types. Now everywhere we called `.wiki?` and expected a boolean, we check that type.
-
- 12 Mar, 2019 1 commit
-
-
Fabio Papa authored
The repository_path is no longer needed since https://gitlab.com/gitlab-org/gitlab-shell/merge_requests/231, which closes https://gitlab.com/gitlab-org/gitlab-shell/issues/135.
-
- 11 Mar, 2019 2 commits
-
-
Bob Van Landuyt authored
Instead of mixing in the shared secret into the querystring or body, we could also specify it in a header.
-
Bob Van Landuyt authored
The behavior for GitLab shell calling `/discover` when a user is not found is currently untested. We are relying on this behaviour to make GitLab reply "Welcome to GitLab, Anonymous!".
-
- 16 Feb, 2019 1 commit
-
-
Stan Hu authored
This will enable us to track the human-readable project path with SSH access in gitlab-shell. Currently the Gitaly logs will only show the hashed storage and gl_repository path (e.g. project-1234).
-
- 14 Feb, 2019 1 commit
-
-
Ash McKenzie authored
When using git-lfs with SSH we weren't passing in the expires_header header which is allows large transfers to succeed in the event the current default of 30 mins expires. https://github.com/git-lfs/git-lfs/blob/master/docs/api/server-discovery.md#ssh
-
- 24 Jan, 2019 1 commit
-
-
Rémy Coutable authored
Signed-off-by:
Rémy Coutable <remy@rymai.me>
-
- 31 Dec, 2018 1 commit
-
-
Jonathon Reinhart authored
gitlab-org/gitlab-shell!166 added support for collecting push options from the environment, and passing them along to the /internal/post_receive API endpoint. This change handles the new push_options JSON element in the payload, and passes them on through to the GitPushService and GitTagPushService services. Futhermore, it adds support for the first push option, ci.skip. With this change, one can use 'git push -o ci.skip' to skip CI pipe execution. Note that the pipeline is still created, but in the "skipped" state, just like with the 'ci skip' commit message text. Implements #18667
-
- 18 Dec, 2018 1 commit
-
-
blackst0ne authored
Updates specs to use new rails5 format. The old format: `get :show, { some: params }, { some: headers }` The new format: `get :show, params: { some: params }, headers: { some: headers }`
-
- 17 Dec, 2018 1 commit
-
-
Ash McKenzie authored
This reverts commit 00acef43.
-
- 16 Dec, 2018 1 commit
-
-
Jasper Maes authored
-
- 05 Dec, 2018 2 commits
-
-
🤖 GitLab Bot 🤖 authored
This reverts commit 22954f22
-
Ash McKenzie authored
LfsToken::HMACToken#token_valid?() will be examined and if false, look in redis via LfsToken::LegacyRedisDeviseToken#token_valid?().
-
- 07 Nov, 2018 1 commit
-
-
Douwe Maan authored
This reverts merge request !22526
-
- 25 Oct, 2018 1 commit
-
-
Tiago Botelho authored
Whenever a git push takes more than 50 seconds the user will receive a trace from each check performed along with their timings
-
- 23 Oct, 2018 1 commit
-
-
blackst0ne authored
-
- 07 Sep, 2018 1 commit
-
-
Rubén Dávila authored
If user has configure the setting then it will be passed to gitlab-shell and gitlab-workhorse
-