- 03 Nov, 2021 1 commit
-
-
Yorick Peterse authored
In MR https://gitlab.com/gitlab-org/gitlab/-/merge_requests/63669 we introduced a new data format for storing merge request diff commit authors and committers. As part of this work we made changes to the import/export code to support this new format, and added a set of migrations to migrate existing data to this new format. At this time we supported reading and writing of data in both the old and new format, allowing us to gradually migrate data over to the new format. In https://gitlab.com/gitlab-org/gitlab/-/merge_requests/72219 we ensured all migrations are done, stopped using the old data format, and removed the columns storing this data. Unfortunately, this chain of events uncovered a bug in our import/export logic. Consider the following timeline of events: 1. You export project "Cooking Recipes" from a GitLab instance running a version earlier than 14.1 (e.g. 14.0). 2. The instance you intend to import this project into is running 14.1 or newer. Existing data has been fully migrated already. 3. You import the project into this new instance. At this point, the imported data is using the old format, not the format. This is because we forgot to take into account users importing exports using GitLab 14.0 or older, instead only covering exports generated using GitLab 14.1 or newer. Because the background migrations finished, or the data imported would fall in a "bucket" (= a chunk or rows to migrate) that had already been migrated, the data would never be updated to the new format. In this commit we resolve this problem in two steps. First, we change the import/export logic to support importing data in both the old and new format. Exports still use the new format. In addition, we include a background migration that processes all projects created using a GitLab import/export since the first mentioned merge request was introduced. For each such project we scan over the merge request diff commits and fix any that are missing the commit author or committer details. For small self-hosted instances this process is unlikely to take more than a few minutes. On GitLab.com however we expect this process to take a few days, as we have to process around 200 000 projects imported since July. This means we'll likely need additional manual intervention similar to the manual work needed for https://gitlab.com/gitlab-org/gitlab/-/issues/334394. See https://gitlab.com/gitlab-org/gitlab/-/issues/344080 for additional details. Changelog: fixed
-
- 02 Nov, 2021 39 commits
-
-
Vitali Tatarintev authored
Enable quarantined service ping metrics See merge request gitlab-org/gitlab!73348
-
Vitaly Slobodin authored
Add reCAPTCHA to password reset and confirmation email forms See merge request gitlab-org/gitlab!72331
-
Sean McGivern authored
Resolve "Gitlab::ApplicationRateLimiter.throttled? key _must_ be a symbol" See merge request gitlab-org/gitlab!73440
-
Rémy Coutable authored
Quarantine flaky user assigns self spec See merge request gitlab-org/gitlab!73355
-
Rémy Coutable authored
Ensure specs are under saas context when needed See merge request gitlab-org/gitlab!72856
-
Illya Klymov authored
Implement loading and error state in DAST scans view See merge request gitlab-org/gitlab!72994
-
Illya Klymov authored
Use GlAvatar in approval rule selector See merge request gitlab-org/gitlab!73334
-
Tetiana Chupryna authored
Change additional_snowplow_tracking feature flag type to Ops See merge request gitlab-org/gitlab!73434
-
Peter Leitzen authored
Make breadcrumb toggle inline See merge request gitlab-org/gitlab!72754
-
Francisco Javier López authored
Fix the offences introduced by Performance/OpenStruct See merge request gitlab-org/gitlab!70900
-
Jan Provaznik authored
Exclude project namespaces from namespace#search See merge request gitlab-org/gitlab!73421
-
Rémy Coutable authored
Default feature labels on feature flag roll-out issue See merge request gitlab-org/gitlab!73513
-
Sean McGivern authored
Fix Feature Category in Tags Controller See merge request gitlab-org/gitlab!73525
-
Shinya Maeda authored
This commit fixes that the specific endpoint on tags controller is categorized in source code management.
-
Sean McGivern authored
Add better error handling to BulkImports::GroupLoader See merge request gitlab-org/gitlab!73191
-
Sean McGivern authored
-
Rémy Coutable authored
Add documentation on test dependency across backend and frontend See merge request gitlab-org/gitlab!73448
-
Alexandru Croitor authored
When searching namespces by path or name we are not expecting to get ProjectNamespaces in results yet, so we need to filter those out for now.
-
Jan Provaznik authored
Remove temporary invite member cookie transfer method See merge request gitlab-org/gitlab!73475
-
Jan Provaznik authored
Run experiment on New Board CTA See merge request gitlab-org/gitlab!72683
-
Adam Hegyi authored
[VSA] Hide warning banner when navigating away See merge request gitlab-org/gitlab!73527
-
Brandon Labuschagne authored
Pluralize DevOps Report to DevOps Reports in UI See merge request gitlab-org/gitlab!73319
-
wortschi authored
-
Marcel Amirault authored
Doc | Improving firewall rules for Geo See merge request gitlab-org/gitlab!73445
-
Priyan Sureshbabu authored
-
Adam Hegyi authored
Refactor specs prevent_cross_database_modification_spec See merge request gitlab-org/gitlab!73451
-
charlie ablett authored
Exclude project namespaces from autocomplete routes finder See merge request gitlab-org/gitlab!72862
-
Dan Jensen authored
DevOps Report (singular) actually refers to 2 features. That has caused confusion. This changes it to be DevOps Reports (plural) in the UI, to indicate it is a category. This aligns the app with the marketing content, which already uses the plural version. This also fixes some references to DevOps Report that should be references to DevOps Adoption or DevOps Score. Changelog: changed
-
Fiona Neill authored
Improve Pages CI/CD instructions See merge request gitlab-org/gitlab!73452
-
Russell Dickenson authored
-
Fiona Neill authored
Crosslink Puma docs See merge request gitlab-org/gitlab!73489
-
Kushal Pandya authored
Refactor labels selector in board scope See merge request gitlab-org/gitlab!71983
-
Florie Guibert authored
-
Dylan Griffith authored
Some time ago we made all specs default to preventing cross database modification. Thus the `prevent_cross_database_modification` tag was unecessary. This meant slightly re-organising the tests and removing 1 redundant test and re-writing one test slightly since it wasn't covered elsewhere.
-
Dylan Griffith authored
-
Jan Provaznik authored
Excludes project namespaces in autocomplete routes finder.
-
Marcel Amirault authored
Add note that buckets should be specified for all object types See merge request gitlab-org/gitlab!72965
-
Alexander Tanayno authored
-
charlie ablett authored
Exclude project namespace when computing subgroup counts See merge request gitlab-org/gitlab!73305
-