An error occurred fetching the project authors.
  1. 17 Jul, 2019 1 commit
    • Stan Hu's avatar
      Fix inconsistency in Redis performance bar stats · 9dd59df6
      Stan Hu authored
      peek-redis resets its counters at the start of an ActionController
      notification (`start_processing.action_controller`), which causes it to
      miss some Redis queries that precede it, such as the database load
      balancer and Rack Attack queries. This produces inconsistencies in the
      performance bar between the number of calls and their durations with the
      actual calls in the detailed view.
      
      We fix this by getting rid of peek-redis in favor of consolidating all
      logic into the `RedisDetailed` view, which tracks Redis queries using
      `RequestStore`. This has the nice property of removing thread-specific
      counters as well.
      
      Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/64707
      9dd59df6
  2. 09 Jul, 2019 1 commit
  3. 03 Jul, 2019 1 commit
    • Stan Hu's avatar
      Add Redis call details in Peek performance bar · dac8e99e
      Stan Hu authored
      Since Redis timings appear to be increasing in production, this change
      makes it easier to see what exactly which queries are being called and
      where.
      
      This is done by prepending modules in peek-redis to store the call
      details.
      
      This commit redact values for all SET commands (e.g. HMSET, GETSET,
      etc.).
      dac8e99e