- 28 Apr, 2021 40 commits
-
-
Sean McGivern authored
-
Sean McGivern authored
A few years ago we set the default number of retries to 3 globally. The reasoning was that we have a lot of jobs that try to communicate with external services, and that those jobs don't need 25 retries - if the service is down, we shouldn't waste our time trying to send to it the other 22 times. I think that this is valid, but it has some problems as a default: 1. Most of our workers don't connect to an external service. 2. 3 retries will happen over a couple of minutes. If - say - our database goes down for 5 minutes, all jobs that we tried during that period will fail completely. If we allow 25 retries then we have a few weeks to fix that issue, which should be sufficient. 3. We're rolling out a change to use fewer Sidekiq queues. Because we have a mixed-stage deployment, we can have jobs scheduled from canary using new worker classes that don't exist on the main stage (which runs Sidekiq) yet. Those jobs would just fail immediately. Setting a higher number of retries lets those jobs succeed once the main stage is deployed - albeit with a delay due to the back-off. The meta-reasoning here is that 25 is the default in Sidekiq for a reason, and in retrospect I think we were too hasty in changing it. Sidekiq is very heavily used software, and its default settings have come out of a lot of hard-won experience. Let's try to use more of that!
-
Sean McGivern authored
Some time ago, we set the default number of Sidekiq retries to 3. In the next commit we're going to change that to 25, but we only want it to apply to new workers. So we'll first need to explicitly set all existing workers to 3. To aid with this, I used the below script. I had to make a couple of tweaks for some worker concerns, but it covered most of the several hundred workers we have: Dir.glob('{ee/,}app/workers/**/*.rb').select do |worker| contents = open(worker).read next unless contents.include?('ApplicationWorker') next if contents.include?('sidekiq_options retry: ') new_contents = contents.gsub(/^( +)include ApplicationWorker$/, "\\1include ApplicationWorker\n\n" + "\\1sidekiq_options retry: 3") open(worker, 'w').puts(new_contents) end
-
Marcia Ramos authored
Docs: Remove create_default examples with freeze See merge request gitlab-org/gitlab!60379
-
Marcia Ramos authored
Document all the configuration options See merge request gitlab-org/gitlab!59562
-
Viktor Nagy authored
-
Marcia Ramos authored
Document order-dependent flaky tests See merge request gitlab-org/gitlab!59369
-
Albert Salim authored
-
Matthias Käppler authored
ImportExport: Validate URL before downloading See merge request gitlab-org/gitlab!60388
-
Rémy Coutable authored
ci: Streamline our usage of 'needs' after latest improvements See merge request gitlab-org/gitlab!60030
-
David O'Regan authored
Change success variant for primary button in upload file modal to confirm See merge request gitlab-org/gitlab!59463
-
Yogi authored
-
Dmytro Zaporozhets (DZ) authored
Merge branch '21033-controller-groups-groupmemberscontroller-index-executes-more-than-100-sql-queries-p80-108-5' into 'master' Resolve admin_group_member group policy n+1 See merge request gitlab-org/gitlab!58948
-
Doug Stull authored
-
Kamil Trzciński authored
Link change management for feature flag rollout in issue template See merge request gitlab-org/gitlab!60470
-
Arturo Herrero authored
Update Usage Ping Metrics Definitions for group::release See merge request gitlab-org/gitlab!60377
-
Marcia Ramos authored
Correct load balancer typo in database load balancing doc See merge request gitlab-org/gitlab!60156
-
Sean McGivern authored
Remove optimized_timebox_queries feature flag [RUN ALL RSPEC] [RUN AS-IF-FOSS] See merge request gitlab-org/gitlab!60326
-
Markus Koller authored
Revert '323357-mlunoe-subscription-plans-service' See merge request gitlab-org/gitlab!59371
-
Michael Lunøe authored
This reverts commit 636c36aa, reversing changes made to ce6ed97f.
-
Dmytro Zaporozhets (DZ) authored
Refresh cache on user for assigned open issues count after cache invalidation [RUN ALL RSPEC] [RUN AS-IF-FOSS] See merge request gitlab-org/gitlab!59961
-
charlie ablett authored
Refresh cache on user for assigned open issues count after cache invalidation [RUN ALL RSPEC] [RUN AS-IF-FOSS]
-
Rémy Coutable authored
Add `static-analysis as-if-foss` job See merge request gitlab-org/gitlab!60363
-
Bob Van Landuyt authored
Fix tier for instance and group DevOps Adoption See merge request gitlab-org/gitlab!60032
-
Mikołaj Wawrzyniak authored
Add Metrics definition JSON schema for histogram metric See merge request gitlab-org/gitlab!58056
-
Alex Kalderimis authored
Add ConfigureSecretDetection graphql mutation See merge request gitlab-org/gitlab!58230
-
Daniel Paul Searles authored
-
Alper Akgun authored
Update Usage Ping Metrics Definitions for 5 min app metrics See merge request gitlab-org/gitlab!60364
-
Alper Akgun authored
Update Usage Ping Metrics Definitions instance auto devops enabled See merge request gitlab-org/gitlab!60374
-
Alina Mihaila authored
-
Alper Akgun authored
Generate Snowplow event dictionary See merge request gitlab-org/gitlab!59484
-
Alishan Ladhani authored
-
Kassio Borges authored
Ensure to validate the URL of an File before downloading it.
-
Arturo Herrero authored
Define and describe metrics retiring process See merge request gitlab-org/gitlab!59000
-
Rémy Coutable authored
Enable invite members modal tests [RUN ALL RSPEC] See merge request gitlab-org/gitlab!60178
-
Jackie Fraser authored
-
Dan Jensen authored
The DevOps Adoption features, which exist at both the instance and group levels, are intended to be Ultimate features and were in the Starter list. Changelog: changed
-
Sean McGivern authored
Document FIPS compliance at GitLab See merge request gitlab-org/gitlab!55208
-
Mark Chao authored
Merge branch 'qmnguyen0711/1016-implement-sidekiq-queue-re-routing-in-the-application-second' into 'master' Implement Sidekiq queue re-routing in the application See merge request gitlab-org/gitlab!59604
-
Quang-Minh Nguyen authored
-