An error occurred fetching the project authors.
  1. 11 Jun, 2018 1 commit
  2. 06 Jun, 2018 3 commits
    • Alexis Reigel's avatar
      create favicon overlay on the client · 01736922
      Alexis Reigel authored
      the initial reason for this change was that graphicsmagick does not
      support writing to ico files. this fact lead to a chain of changes:
      
      1. use png instead of ico (browser support is good enough)
      2. render the overlays on the client using the canvas API. this way we
         only need to store the original favion and generate the overlay versions
         dynamically.
         this change also enables (next step) to simplify the handling of the
         stock favicons as well, as we don't need to generate all the versions
         upfront.
      01736922
    • Alexis Reigel's avatar
      call Gitlab::Favicon.status in serializer · 03b3016c
      Alexis Reigel authored
      this ways we can keep the `lib/gitlab/ci/status/*` classes to return the
      bare favicon name as it was before.
      
      also the favicon uploader versions are now have the same names as the
      stock favicons (+ `favicon_` prefix), which makes working with the
      status names easier.
      03b3016c
    • Alexis Reigel's avatar
      e0357414
  3. 05 Jun, 2018 3 commits
    • Alexis Reigel's avatar
      create favicon overlay on the client · 9e14f437
      Alexis Reigel authored
      the initial reason for this change was that graphicsmagick does not
      support writing to ico files. this fact lead to a chain of changes:
      
      1. use png instead of ico (browser support is good enough)
      2. render the overlays on the client using the canvas API. this way we
         only need to store the original favion and generate the overlay versions
         dynamically.
         this change also enables (next step) to simplify the handling of the
         stock favicons as well, as we don't need to generate all the versions
         upfront.
      9e14f437
    • Alexis Reigel's avatar
      call Gitlab::Favicon.status in serializer · 67fe0a17
      Alexis Reigel authored
      this ways we can keep the `lib/gitlab/ci/status/*` classes to return the
      bare favicon name as it was before.
      
      also the favicon uploader versions are now have the same names as the
      stock favicons (+ `favicon_` prefix), which makes working with the
      status names easier.
      67fe0a17
    • Alexis Reigel's avatar
      c8a4d202