Pass GITLAB_REF_SLUG to CNG triggered pipelines

See merge request gitlab-org/gitlab-ce!23435

Backport of draft-design-improvements changes

See merge request gitlab-org/gitlab-ce!23438

Store hashed storage paths in the database

See merge request gitlab-org/gitlab-ce!23143

Fix horizontal scrollbar overlapping content everywhere, #51296.

Closes #51296

See merge request gitlab-org/gitlab-ce!23167

Display commit ID for commit diff discussion on merge request

See merge request gitlab-org/gitlab-ce!23370

Retry the review-qa-smoke job twice

Closes #54610

See merge request gitlab-org/gitlab-ce!23440

Fix Environment terminal specs for EE

See merge request gitlab-org/gitlab-ce!23421

Docs: add link to the docs site from /help landing page

See merge request gitlab-org/gitlab-ce!23434

Merge branch 'docs/8608-update-approval-guidelines-to-include-red-orange-data-reviews' into 'master'

Add RED data security requirement to code review

See merge request gitlab-org/gitlab-ce!23426

Remove link that is broken now

See merge request gitlab-org/gitlab-ce!23427

Commits API: Preserve file content in move operations if unspecified

Closes #52974 et #51083

See merge request gitlab-org/gitlab-ce!23387

Also, enable debug mode.
Signed-off-by: Rémy Coutable <remy@rymai.me>

Improve traceability for failed attempts of archiving traces

Closes #51502

See merge request gitlab-org/gitlab-ce!21826

Encourage MR author preparation in Code Review Guidelines documentation

See merge request gitlab-org/gitlab-ce!23360

Remove needless auto-capitalization on Wiki page titles

Closes #38317

See merge request gitlab-org/gitlab-ce!23288

Add config to prohibit impersonation

See merge request gitlab-org/gitlab-ce!23338

Signed-off-by: Rémy Coutable <remy@rymai.me>

Make RemoteMirror's only_protected_branches default value consistent

See merge request gitlab-org/gitlab-ce!23410

Added frontend GraphQL docs

See merge request gitlab-org/gitlab-ce!23405

Adds gitlab.impersonation_enabled config option defaulting to true to
keep the current default behaviour.

Only the act of impersonation is modified, impersonation token
management is not affected.

Add a rebase API endpoint for merge requests

Closes #33705

See merge request gitlab-org/gitlab-ce!23296

In EE we redefine Environment#terminals, which makes it impossible to
use `allow_any_instance_of(Environment)` or
`expect_any_instance_of(Environment)`. Other approaches of stubbing
this class, such as by stubbing `new`, only result in spec failures.

To solve this issue, we add a simple `defined?(EE)` check in the tests
to change the thing that we are testing. This is rather obnoxious,
because it requires EE knowledge in CE, and can break if
`EE::Environment` is removed without updating CE. Unfortunately, it
appears to be the only solution we have apart from modifying these tests
in EE (which would cause merge conflicts).

commit 10456b1e9240886432f565dd17689080bbb133b9
Merge: 312c1a9bdf8 a5f46278
Author: Shinya Maeda <shinya@gitlab.com>
Date:   Thu Nov 29 14:33:21 2018 +0900

    Merge branch 'master-ce' into add-counter-for-trace-chunks

commit 312c1a9bdf8efc45c3fed5ff50f05cc589bbb4ed
Author: Shinya Maeda <shinya@gitlab.com>
Date:   Wed Nov 28 20:06:18 2018 +0900

    Fix coding offence

commit e397cc2ccc1b2cf7f8b3558b8fa81fe2aa0ab366
Author: Shinya Maeda <shinya@gitlab.com>
Date:   Wed Nov 28 14:40:24 2018 +0900

    Fix tracking archive failure

Update documentation with note regarding restoring ssh host keys

See merge request gitlab-org/gitlab-ce!23392

Bump gitlab-shell to 8.4.3

See merge request gitlab-org/gitlab-ce!23429