- 08 Feb, 2021 40 commits
-
-
Dylan Griffith authored
These count requests are loaded one per tab every time the search page loads. This means a single search for one type of document will trigger up to 7 other searches just to get the counts for the other tabs. These tab counts are often incredibly expensive requests too especially relative to the cheaper searches. For example an issue search may take 1s while a blobs count will take 30s. Due to a limited thread pool on the Elasticsearch side we regularly see these count queries being the cause of queuing which is slowing down otherwise fast searches on GitLab.com. As such we want to set a timeout on these. This timeout is just a server side Elasticsearch timeout for now which is a soft limit because Elasticsearch is asynchronous and it may actually take Elasticsearch longer to realise it's timed out and cancel the query. As such we may see searches take a few seconds before they timeout even though the timeout is 1s. This is not perfect but benchmarking in the related issue shows this still can drastically improve throughput and this is one of the easiest steps to take now. One thing to also note about this approach is that users will still see a count in the event of a timeout. The count may be a partial count and actually lower than the true count. If they switch to the tab they will see a true count. I think this is probably still better than displaying nothing since the main value the tab counts have is showing whether or not there are searches on that tab at all. Later we may wish to introduce client side timeouts on our ES client but it's trickier to accomplish since we use a single client configuration which has a global timeout for all Elasticsearch queries. Additionally client side timeouts will result in errors that we may wish to handle specially to show some indicator on the tab. Read more at https://gitlab.com/gitlab-org/gitlab/-/issues/301146
-
Mayra Cabrera authored
Fix ruby keyword warning in gitlab_experiment.rb See merge request gitlab-org/gitlab!53444
-
Stan Hu authored
Improve Tracking for 4 experiments in onboarding flow See merge request gitlab-org/gitlab!53583
-
Russell Dickenson authored
docs: Update secure eslint scanner with severity See merge request gitlab-org/gitlab!53502
-
Nick Gaskill authored
Fix doc to use the latest deployment template See merge request gitlab-org/gitlab!53331
-
Shinya Maeda authored
-
Craig Norris authored
Initial idea for a front matter test See merge request gitlab-org/gitlab!52844
-
Amy Qualls authored
Add the rudiments of a test that flags Markdown files in the doc/ directory that do not have front matter. Files without front matter won't show up in the Technical Writing team's calculations.
-
Amy Qualls authored
Added docs for requesting a new review See merge request gitlab-org/gitlab!53377
-
Phil Hughes authored
Remove a screenshot that is better handled by phrasing. Convert narration to a procedure, and add some extra missing steps. Move a subheading to the bottom of the page, as it's only required for one version of GitLab.
-
Kerri Miller authored
Update rollout issue links for Code Review flags See merge request gitlab-org/gitlab!53621
-
Mike Jang authored
Fix test code snippet for tracking Redis events See merge request gitlab-org/gitlab!53603
-
Craig Norris authored
Add links from 2FA feature flags to affected features See merge request gitlab-org/gitlab!53277
-
Mike Jang authored
-
Yannis Roussos authored
Database testing using thin-clones See merge request gitlab-org/gitlab!51347
-
Andreas Brandl authored
Relates to https://gitlab.com/gitlab-org/database-team/team-tasks/-/issues/128
-
Scott Hampton authored
Apply new GitLab UI in create MR button and input from issue See merge request gitlab-org/gitlab!53467
-
Kerri Miller authored
Use Gitaly keyset pagination to optimize branches page See merge request gitlab-org/gitlab!53409
-
Douglas Barbosa Alexandre authored
GraphQL: Add descriptions to ServiceTypeEnum See merge request gitlab-org/gitlab!53515
-
Tanya Pazitny authored
Update testcase links in manage and secure specs See merge request gitlab-org/gitlab!53636
-
Nick Gaskill authored
Docs: Add link to coverage-fuzzing AFL example See merge request gitlab-org/gitlab!53560
-
Yevgeny Pats authored
-
Kerri Miller authored
Track approver metrics for a merge request See merge request gitlab-org/gitlab!53201
-
David Kim authored
-
Andrew Fontaine authored
Update sidebartogglebutton Template See merge request gitlab-org/gitlab!52680
-
Jannik Lehmann authored
The sidebartogglebutton Template produced invalid HTML output, this commit fixes that.
-
Robert Speicher authored
Limit trial status widget experiment participants to group owners See merge request gitlab-org/gitlab!52537
-
Douglas Barbosa Alexandre authored
Add service to update Dast::Profile See merge request gitlab-org/gitlab!51952
-
Philip Cunningham authored
-
Nick Gaskill authored
Add FREE badging to pages with CORE See merge request gitlab-org/gitlab!53522
-
Natalia Tepluhina authored
Make System OAuth app index table responsive and externalize text See merge request gitlab-org/gitlab!50979
-
Kev authored
-
Mike Jang authored
Update doc/administration/compliance.md See merge request gitlab-org/gitlab!53606
-
Saumya Upadhyaya authored
-
Lucas Charles authored
As of 13.8, eslint now returns a severity, see https://gitlab.com/groups/gitlab-org/-/epics/4004
-
Kamil Trzciński authored
Mark pages as not deployed and remove domains synchrounsly See merge request gitlab-org/gitlab!53137
-
Yogi authored
-
Yogi authored
-
Yogi authored
-
Yogi authored
-