- 10 Aug, 2017 22 commits
-
-
Yorick Peterse authored
This changes various controllers to use the new EventCollection class for retrieving events. This class uses a JOIN LATERAL query on PostgreSQL to retrieve queries in a more efficient way, while falling back to a simpler / less efficient query for MySQL. The EventCollection class also includes a limit on the number of events to display to prevent malicious users from cycling through all events, as doing so could put a lot of pressure on the database. JOIN LATERAL is only supported on PostgreSQL starting with version 9.3.0 and as such this optimisation is only used when using PostgreSQL 9.3 or newer.
-
Yorick Peterse authored
This commit migrates events data in such a way that push events are stored much more efficiently. This is done by creating a shadow table called "events_for_migration", and a table called "push_event_payloads" which is used for storing push data of push events. The background migration in this commit will copy events from the "events" table into the "events_for_migration" table, push events in will also have a row created in "push_event_payloads". This approach allows us to reclaim space in the next release by simply swapping the "events" and "events_for_migration" tables, then dropping the old events (now "events_for_migration") table. The new table structure is also optimised for storage space, and does not include the unused "title" column nor the "data" column (since this data is moved to "push_event_payloads"). == Newly Created Events Newly created events are inserted into both "events" and "events_for_migration", both using the exact same primary key value. The table "push_event_payloads" in turn has a foreign key to the _shadow_ table. This removes the need for recreating and validating the foreign key after swapping the tables. Since the shadow table also has a foreign key to "projects.id" we also don't have to worry about orphaned rows. This approach however does require some additional storage as we're duplicating a portion of the events data for at least 1 release. The exact amount is hard to estimate, but for GitLab.com this is expected to be between 10 and 20 GB at most. The background migration in this commit deliberately does _not_ update the "events" table as doing so would put a lot of pressure on PostgreSQL's auto vacuuming system. == Supporting Both Old And New Events Application code has also been adjusted to support push events using both the old and new data formats. This is done by creating a PushEvent class which extends the regular Event class. Using Rails' Single Table Inheritance system we can ensure the right class is used for the right data, which in this case is based on the value of `events.action`. To support displaying old and new data at the same time the PushEvent class re-defines a few methods of the Event class, falling back to their original implementations for push events in the old format. Once all existing events have been migrated the various push event related methods can be removed from the Event model, and the calls to `super` can be removed from the methods in the PushEvent model. The UI and event atom feed have also been slightly changed to better handle this new setup, fortunately only a few changes were necessary to make this work. == API Changes The API only displays push data of events in the new format. Supporting both formats in the API is a bit more difficult compared to the UI. Since the old push data was not really well documented (apart from one example that used an incorrect "action" nmae) I decided that supporting both was not worth the effort, especially since events will be migrated in a few days _and_ new events are created in the correct format.
-
Filipa Lacerda authored
Remove affix plugin from issuable sidebar with new navigation See merge request !13449
-
Phil Hughes authored
Render new issue link in failed job as a regular link instead of a UJS one Closes #36158 See merge request !13450
-
Rémy Coutable authored
Added a template for database changes See merge request !12355
-
Sean McGivern authored
Fix conflicting redirect search See merge request !13357
-
Yorick Peterse authored
This template includes a rather large (but fairly easy to follow) checklist. This checklist should hopefully take away quite a bit of work from database specialists by requiring authors to provide all the necessary info. [ci skip]
-
Phil Hughes authored
Aligns OR separater to center properly Closes #36185 See merge request !13446
-
Rémy Coutable authored
Include RE2 in the upgrade docs See merge request !13448
-
Filipa Lacerda authored
-
Rémy Coutable authored
Remove unused `redirect_to_external_issue_tracker` method See merge request !13444
-
Nick Thomas authored
-
Rémy Coutable authored
Updating Gemfile.lock for rubocop-rspec dependecy. See merge request !13410
-
Phil Hughes authored
This isn't required with the new navigation as it is always position fixed so we are just creating a scroll event listener that will never actually do anything
-
Filipa Lacerda authored
-
Rémy Coutable authored
alternative route for download archive See merge request !13439
-
haseeb authored
-
Filipa Lacerda authored
Fix the sticky changes bar on commits page See merge request !13343
-
Filipa Lacerda authored
Removed display styles when hiding the fly out navigation Closes #36224 See merge request !13431
-
Filipa Lacerda authored
-
Mehdi Lahmam authored
Its usage has been removed at 2fa22a07.
-
Rémy Coutable authored
Add missing command to compile GetText files See merge request !13437
-
- 09 Aug, 2017 18 commits
-
-
Sean McGivern authored
Rename RPC 'Exists' to 'RepositoryExists' See merge request !13277
-
Grzegorz Bizon authored
Fix proxy config in Gitlab Pages nginx examples See merge request !13375
-
Rubén Dávila authored
-
Robert Speicher authored
Don't include anything to Kernel only because of tasks Closes #36003 See merge request !13380
-
Robert Speicher authored
Prevent user from changing username with container registry tags Closes #35451 See merge request !13356
-
Michael Kozono authored
-
Jacob Vosmaer authored
-
Robert Speicher authored
Enable the Layout/SpaceBeforeBlockBraces cop See merge request !13413
-
Phil Hughes authored
-
Phil Hughes authored
Update icon color on hover Closes #35996 See merge request !13393
-
Michael Kozono authored
-
Annabel Dunstone Gray authored
Fixed merge request changes sticky container not spreading full width See merge request !13386
-
Rémy Coutable authored
Signed-off-by: Rémy Coutable <remy@rymai.me>
-
Phil Hughes authored
Closes #36224
-
Phil Hughes authored
Align all nav items in sidebar Closes #36179 See merge request !13392
-
Phil Hughes authored
Fix height of collapsed sidebar items See merge request !13385
-
Sean McGivern authored
Explain why we use select all for project_url_constrainer.rb See merge request !13425
-
Tim Zallmann authored
Fix Pikaday being undefined Closes #36207 See merge request !13422
-