Since `system` notes have different permissions to normal notes on
issues we do not want to include them in the ElasticSearch index. The
reason being that the authorization logic we have in place for searching
for notes is only accounting for the non-system notes.

We have been under the impression that `system` notes have not been
getting indexed already because we were filtering them out in 2
different places already:

1. When new notes are created
https://gitlab.com/gitlab-org/gitlab/blob/2b607f0916c880a6c947ebfe4f4ee32f43fba551/ee/app/models/concerns/elastic/application_versioned_search.rb#L37
2. When indexing a whole project https://gitlab.com/gitlab-org/gitlab/blob/2b607f0916c880a6c947ebfe4f4ee32f43fba551/ee/app/models/concerns/elastic/projects_search.rb#L29

But there is a 3rd way in which notes get updated in the index which was
added in
https://gitlab.com/gitlab-org/gitlab/commit/db6a45ec17b2d165e85979dd7357e967d4346faa
. This is triggered when some auth related settings of an Issue are
updated as this changes who will be able to read notes in the issue so
it is updating all the notes for that issue. This third piece of logic
was now inserting all the system notes and should have been skipping
them like all other places where notes are added.

Also ignore Rubocop since this was like this before and we're fixing a
security vulnerability.

Refactor checksum code on uploads

Closes #12764

See merge request gitlab-org/gitlab!18065

- create the checksummable concern file

Add backend support for selecting custom templates by ID

See merge request gitlab-org/gitlab!18178

Add test for configurable issue board

See merge request gitlab-org/gitlab!18228

Resolve "Flaky spec/finders/members_finder_spec.rb:85"

Closes #31427

See merge request gitlab-org/gitlab!18257

Geo: Handle race condition on design update

Closes #13052

See merge request gitlab-org/gitlab!17814

Geo: Handle race condition for container synchronization

Closes #32899

See merge request gitlab-org/gitlab!17823

Revert com code segregation

See merge request gitlab-org/gitlab!18212

This reverts commit 9ff8b86e, reversing
changes made to 2c163449.

Productivity Analytics: Add transformScatterData utility method

See merge request gitlab-org/gitlab!18249

Transforms the raw scatter data into
a two-dimensional array

Remove list_directoriers

See merge request gitlab-org/gitlab!18224

Respect Group SSO Enforcement on projects where the user is an owner

Closes #33302

See merge request gitlab-org/gitlab!18154

Productivity Analytics: Change default timeframe to 30 days

See merge request gitlab-org/gitlab!18215

- Fetches data for the last 30 days

Allow the 'schedule:package-and-qa' job to fail for now

See merge request gitlab-org/gitlab!18270

Signed-off-by: Rémy Coutable <remy@rymai.me>

Productivity Analytics: Tweak style for scatterplot trendline

See merge request gitlab-org/gitlab!18247

Use different color for the trendline and bring to front

This is the first step to fixing
https://gitlab.com/gitlab-org/gitlab/issues/9146 and adds the backend
support in https://gitlab.com/gitlab-org/gitlab/merge_requests/17205.

The backend support is added first to avoid no-downtime issues with
creating new projects.

Change ECDSA key validator to check the asn1 flag instead

Closes #33216

See merge request gitlab-org/gitlab!18017

Using optimistic locking when finishing design sync

[Docs] Start documenting our internal API

See merge request gitlab-org/gitlab!18089

Extract Issuables System Note Service

Closes #17597

See merge request gitlab-org/gitlab!17818

This is an attempt to get a grasp on what we're doing in our internal
API calls. Next steps would be removing dead code and perhaps
splitting up complicated calls.

Fixes the validation with OpenSSL 1.1

Properly handle 503 errors in info/refs endpoint

Closes #32925

See merge request gitlab-org/gitlab!18177

Update artifact size authorization

See merge request gitlab-org/gitlab!17769

Enable frozen string for spec/views

See merge request gitlab-org/gitlab!18171

Partially addresses:

https://gitlab.com/gitlab-org/gitlab/issues/27703

Add Engineering Productivity code owners

See merge request gitlab-org/gitlab!17959

Fix Prometheus Alert Worker spec

Closes #33605

See merge request gitlab-org/gitlab!18243

Change Prometheus Alert issue details list from bulleted to description list

See merge request gitlab-org/gitlab!18116

Using optimistic locking when finishing container sync

Add version information to CI exists rule

See merge request gitlab-org/gitlab!18251