Merge branch '33489-rename-settings-panel-close-action-to-collapse-to-avoid-confusion-ee' into 'master'

Port Resolve "Rename settings panel "close" action to "collapse" to avoid confusion" to EE

See merge request !2096

Move Elasticsearch indexer into run_after_commit

Closes #2712

See merge request !2214

Elasticsearch queries should retry on failure

Closes #2681

See merge request !2181

Change title of Code quality docs

See merge request !2204

Geo config - Move "regenerate authorized keys" step (step 6) of config to before step 4

See merge request !2218

Link to instructions on how to build a custom OpenSSH package

See merge request !2206

Normalise license MD5 values

See merge request !2205

Closes #2712

Fix remaining DotPosition cops 👮

Closes #2710

See merge request !2211

Introduced in
https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/2201

Fix broken time sync leeway with Geo

See merge request !2208

Previous versions did not properly set the IAT leeway properly, causing
many Geo API requests to be marked invalid. The problem was that
the ruby-jwt `master` used `iat_leeway` as the parameter, but v1.5.6
actually used `leeway`.

Use curl --remote-name instead of curl -O to fix broken docs lint

See merge request !2209

CE to EE: refactor projects finder init collection ee

See merge request !2199

EE version: Clean up the Project model to reduce conflicts

See merge request !2056

Moves remote mirror, import and fork workers to their own queue

See merge request !2177

Add Rubocop Style/DotPosition Cop

See merge request !2201

[ci skip]

License files uploaded in the UI always have newlines as separators, with a
single trailing newline.

Licenses pasted in the text box will have newlines replaced by \r\n by the
browser, and may have zero trailing newlines, or many.

Normalising these to a canonical form lets us match against the license app more
efficiently.

The spec filename does not match the module/class name. But ignore it, because
the `ee` subdir is added in between to avoid conflicts when merging from CE.

Fix typo with custom OpenSSH build instructions

See merge request !2202

Namespace license checks for exporting issues (EES)

Closes #2584

See merge request !2164

Fix transient remove issue from board and see milestone removed spec

Closes #2660

See merge request !2139

[ci skip]

Fix Vue warnings in the MR Widget (EE)

See merge request !2192

Fix Vue warnings about string idKey in Related Issues

See merge request !2190

Add instructions for setting up a custom version of OpenSSH for Geo

See merge request !2191

CE and EE implement this differently, so abstract it out of VisibilityLevel.

To limit the number of CE merge conflicts, move the auditor role code outside
the original User model and into the EE-specific mixin.

The permitted visibility levels for an auditor user should also include private,
because it has read-only access to every project/group on the GitLab instance.

This optimises how GroupProjectsFinder builds it collection, producing
simpler and faster queries in the process. It also cleans up the code a
bit to make it easier to understand.

This method used to use a UNION, which would lead to it performing the
same query twice; producing less than ideal performance. Further, in
certain cases ActiveRecord could get confused and mess up the variable
bindings, though it's not clear how/why exactly this happens.

Fortunately we can work around all of this by building some of the WHERE
conditions manually, allowing us to use a simple OR statement to get all
the data we want without any of the above problems.

This changes ProjectsFinder#init_collection so it no longer relies on a
UNION. For example, to get starred projects of a user we used to run:

    SELECT projects.*
    FROM projects
    WHERE projects.pending_delete = 'f'
    AND (
        projects.id IN (
            SELECT projects.id
            FROM projects
            INNER JOIN users_star_projects
                ON users_star_projects.project_id = projects.id
            INNER JOIN project_authorizations
                ON projects.id = project_authorizations.project_id
            WHERE projects.pending_delete = 'f'
            AND project_authorizations.user_id = 1
            AND users_star_projects.user_id = 1

            UNION

            SELECT projects.id
            FROM projects
            INNER JOIN users_star_projects
                ON users_star_projects.project_id = projects.id
            WHERE projects.visibility_level IN (20, 10)
            AND users_star_projects.user_id = 1
        )
    )
    ORDER BY projects.id DESC;

With these changes the above query is turned into the following instead:

    SELECT projects.*
    FROM projects
    INNER JOIN users_star_projects
        ON users_star_projects.project_id = projects.id
    WHERE projects.pending_delete = 'f'
    AND (
        EXISTS (
            SELECT 1
            FROM project_authorizations
            WHERE project_authorizations.user_id = 1
            AND (project_id = projects.id)
        )
        OR projects.visibility_level IN (20,10)
    )
    AND users_star_projects.user_id = 1
    ORDER BY projects.id DESC;

This query in turn produces a better execution plan and takes less time,
though the difference is only a few milliseconds (this however depends
on the amount of data involved and additional conditions that may be
added).