- 11 Mar, 2021 40 commits
-
-
Dylan Griffith authored
This relates to some more possible edge cases we may have in our data. Since we are running a migration to backfill all these settings that will run forever unless a value is set it is better to always have some fallback that isn't `nil` as the migration will never finish. In this case we can be sure that anything that is required to have a project but doesn't for whatever reason shouldn't show up in searches and therefore it's safe to just set `*_access_level = DISABLED`.
-
Dylan Griffith authored
Prior to this we were specifically targetting missing commits because this was a case we [observed in staging](https://gitlab.com/gitlab-org/gitlab/-/merge_requests/55878) but we also may have more cases we haven't run into yet for other noteable types. The `noteable_id` column on the table does not have a `NOT NULL` constraint nor does it have foreign key references so it's totally conceivable there are other kinds of orphaned notes (eg. issues that were hard deleted at some point) that we don't know about. I have concerns that any one of these situations could again lead to the migration to update permissions getting stuck forever. As such I think the best course of action is to delete any of these. I also can't think of any good reason to keep the orphaned notes in the index so this seems quite safe.
-
Dylan Griffith authored
We discovered at https://gitlab.com/gitlab-org/gitlab/-/merge_requests/55878 that there are sometimes orphaned commit notes. Since these are making it difficult to migrate as we can't set the permissions correctly for these and also since you can't actually navigate to a note on a deleted commit there is no point in keeping these in the index. This commit was extracted from a combined MR at https://gitlab.com/gitlab-org/gitlab/-/merge_requests/55883 so it could be merged independently from the migration.
-
Fabio Pitino authored
Remove latest_builds_report_results preloading in pipeline serializer See merge request gitlab-org/gitlab!56181
-
Nick Gaskill authored
Clarify the use of registry_api_url See merge request gitlab-org/gitlab!56106
-
Olena Horal-Koretska authored
Apply new GitLab UI for buttons on GitHub Import page See merge request gitlab-org/gitlab!56096
-
Yogi authored
-
Dan Davison authored
Fix allow settings for maven duplicates See merge request gitlab-org/gitlab!56100
-
David Fernandez authored
Add info column into security_scans table See merge request gitlab-org/gitlab!55983
-
Vitali Tatarintev authored
Remove `multiple_http_integrations_custom_mapping` feature flag [RUN ALL RSPEC] [RUN AS-IF-FOSS] See merge request gitlab-org/gitlab!56021
-
Olena Horal-Koretska authored
Remove `multiple_http_integrations_custom_mapping` feature flag
-
Brandon Labuschagne authored
Show branch info in DAST profiles library See merge request gitlab-org/gitlab!56019
-
Paul Gascou-Vaillancourt authored
Add branch information to the DAST profiles library.
-
Sean McGivern authored
Remove incorrectly added optional params from Project update params [RUN ALL RSPEC] [RUN AS-IF-FOSS] See merge request gitlab-org/gitlab!56180
-
David Kim authored
Remove incorrectly added optional params from Project update params [RUN ALL RSPEC] [RUN AS-IF-FOSS]
-
Simon Knox authored
Change members to billable members in frontend See merge request gitlab-org/gitlab!55824
-
David Fernandez authored
Reapply !53803 Allow saving repository weights after a storage has been removed - [RUN ALL RSPEC] [RUN AS-IF-FOSS] See merge request gitlab-org/gitlab!55689
-
David Fernandez authored
Add Postman API specification mode to API fuzzing CI configuration page See merge request gitlab-org/gitlab!55601
-
Avielle Wolfe authored
Now that the Secure stage namespace documentation has been merged we should be making use of it.
-
Vitali Tatarintev authored
Introduce MarkerRange class [RUN ALL RSPEC] [RUN AS-IF-FOSS] See merge request gitlab-org/gitlab!55669
-
Gabriel Mazetto authored
Create dast_failed_site_validations feature flag [RUN ALL RSPEC] [RUN AS-IF-FOSS] See merge request gitlab-org/gitlab!56146
-
Marcia Ramos authored
Info about the gitlab.com KAS instance See merge request gitlab-org/gitlab!55593
-
Viktor Nagy authored
-
Vasilii Iakliushin authored
-
Simon Knox authored
Boards new list for Assignee See merge request gitlab-org/gitlab!56151
-
Sanad Liaquat authored
Fix file locking e2e tests See merge request gitlab-org/gitlab!56307
-
Phil Hughes authored
Revise bad warning message: remove comma splice See merge request gitlab-org/gitlab!56115
-
Amy Qualls authored
Fix malformed sentence in the warning shown when a user tries to edit a comment that has changed.
-
Markus Koller authored
Fix typo in wiki.rb See merge request gitlab-org/gitlab!56285
-
Chad Woolley authored
In this commit we fix a typo (`reponse` vs. `response`) and also the method call `response_api_error!` that was lacking one argument.
-
Grzegorz Bizon authored
Improve MR Retarget Chain to prefer usage of `MR::DeleteSourceBranchWorker` See merge request gitlab-org/gitlab!56233
-
Nicolò Maria Mezzopera authored
Merge branch '239850-convert-stylesheets-pages-members-scss-into-page-specific-bundle' into 'master' Convert `members.scss` into page specific bundle See merge request gitlab-org/gitlab!56278
-
Nicolò Maria Mezzopera authored
Add Jira Issue Note component See merge request gitlab-org/gitlab!56068
-
Miguel Rincon authored
Merge branch '300750-add-missing-reviewers-information-to-new_mention_in_merge_request_email' into 'master' Add reviewer information to new_mention_in_merge_request_email See merge request gitlab-org/gitlab!56184
-
Kushal Pandya authored
Add stylelint cache file to .gitignore See merge request gitlab-org/gitlab!56302
-
Simon Knox authored
Lot of vuex duplication that can be trimmed down later
-
Kushal Pandya authored
Improved award emoji picker [RUN ALL RSPEC] [RUN AS-IF-FOSS] See merge request gitlab-org/gitlab!54469
-
Lin Jen-Shin authored
Add ci pattern to migration See merge request gitlab-org/gitlab!56185
-
Rémy Coutable authored
Handle commits without descriptions for changelogs See merge request gitlab-org/gitlab!56224
-
Rémy Coutable authored
Resolve "Follow-up from "Remove safe navigation operator from Vulnerability description"" See merge request gitlab-org/gitlab!53192
-