This would cause us to keep track of a reference of all metrics on the
class level.

Which would mean we would keep looking at the old metrics the registry
in that we kept track of in [Prometheus::Client::Registry#metrics][0]
after it was reset using[Gitlab::Metrics.reset_registry][1].

This wouldn't cause any issues in production, because the metrics are
never reset. But in specs, we do count on those being reset in between
runs.

This is safe to do, because the registry itself is memoized on
[Gitlab::Metrics][2].

Getting the specific metric is an [initialization the first time
around][3], but after a registry is memoized, it's just a [read from a
hash][4].

[0] https://gitlab.com/gitlab-org/prometheus-client-mmap/-/blob/9e5b696dfd47a96cf22808cbebb04f00cd3d4ffc/lib/prometheus/client/registry.rb#L17
[1] https://gitlab.com/gitlab-org/gitlab/blob/82db58bab85531e49fa7264d6461928d49425a6e/lib/gitlab/metrics/prometheus.rb#L30
[2] https://gitlab.com/gitlab-org/gitlab/blob/82db58bab85531e49fa7264d6461928d49425a6e/lib/gitlab/metrics/prometheus.rb#L39
[3] https://gitlab.com/gitlab-org/gitlab/blob/82db58bab85531e49fa7264d6461928d49425a6e/lib/gitlab/metrics/prometheus.rb#L87
[4] https://gitlab.com/gitlab-org/prometheus-client-mmap/-/blob/9e5b696dfd47a96cf22808cbebb04f00cd3d4ffc/lib/prometheus/client/registry.rb#L56

Pushing this in a separate commit so we can watch the specs fail later
and see the follow up fix them.

Merge branch '229696-migrate-deprecatedmodal2-to-glmodal-in-app-assets-javascripts-vue_shared-components-gl_modal' into 'master'

Remove unused shared gl_modal.vue component

See merge request gitlab-org/gitlab!47390

Remove gl-button from star button

See merge request gitlab-org/gitlab!47446

Add Epics Swimlanes documentation

See merge request gitlab-org/gitlab!46635

Disable a custom tooltip initialization

See merge request gitlab-org/gitlab!46427

Fix comment for diff note images

See merge request gitlab-org/gitlab!47400

Fixes multi line comments options in parallel mode

See merge request gitlab-org/gitlab!45557

Add documentation for the Web IDE command palette

See merge request gitlab-org/gitlab!45869

Update Project Security Dashboard Spec

See merge request gitlab-org/gitlab!47332

Improve thread safety of Ci::BuildTraceChunk data stores

See merge request gitlab-org/gitlab!46717

Fix secure MR widget background colors in dark mode

See merge request gitlab-org/gitlab!47352

Schedule clean up of merge request refs efficiently

See merge request gitlab-org/gitlab!46758

Code quality severity icons

See merge request gitlab-org/gitlab!46829

Adding badges to the code quality for severity

Swimlanes - Hide epic lanes with 0 issues

See merge request gitlab-org/gitlab!47257

Boards - Create new issue in GraphQL [RUN AS-IF-FOSS]

See merge request gitlab-org/gitlab!46747

Handle invalid strings in authorization headers

See merge request gitlab-org/gitlab!47206

Add integration with BE based on mocks

See merge request gitlab-org/gitlab!47019

Add CI job to Terraform state version GraphQL type

See merge request gitlab-org/gitlab!47339

Updated service desk incoming email to use custom email

See merge request gitlab-org/gitlab!46053

Add background migrations for Elasticsearch

See merge request gitlab-org/gitlab!46672

This MR implements elastic migration framework, which looks and behaves
similar to rails database migrations.
Migrations are stored in ee/elastic/migrate/ with
YYYYMMDDHHMMSS_migration_name.rb file name format

Update rake to v13

See merge request gitlab-org/gitlab!47318

Use closed icons for issue and epics

See merge request gitlab-org/gitlab!47176

Add region field to AWS Role

See merge request gitlab-org/gitlab!47209

Add migration to add field to AWS Role.
Update AuthorizeRoleService and FetchCredentialsService
to use new region field.

Generate package events file

See merge request gitlab-org/gitlab!47118

hAdd a rule to enforce resolver type annotations

See merge request gitlab-org/gitlab!47375

This new rubocop rule enforces that all resolvers declare their type.

This is important for several reasons:

- developers can read a resolver and know what it does, by understanding
  what it is meant to return.
- we can enable better testing of resolvers, by creating fields from
  resolvers using `Resolver.field_options`.
- Resolvers become the SSOT for field metadata, enabling us to eliminate
  repetition and boilerplate.

Add VueX action to create issue using graphQL mutation

Fetch available issue types in Jira integration for vulnerabilities

See merge request gitlab-org/gitlab!47046

This change adds fetching availalbe issue types for Jira integration for
vulnerabilities when the integration is being tested.

Remove hardcoded ID from spec

See merge request gitlab-org/gitlab!47462

Added destroy command to base Terraform template

See merge request gitlab-org/gitlab!46777