- 29 Jan, 2021 21 commits
-
-
Lin Jen-Shin authored
`ActiveSupport::Concern` uses an unusual way to chain class methods, which does not exactly follow how Ruby chains the classes. In particular, it's like Concern reinvents the object model and builds the ancestors chain in runtime, rather than at the compile time. This for sure introduced a lot of culprits. This fix is aiming for restoring the class methods for the module which is defining the class methods. To be specific, consider this case: ``` ruby module Base extend ActiveSupport::Concern class_methods do def f end end end module Derived include Base end ``` What would you expect for this? ``` ruby Base.f # => NoMethodError Derived.f # => nil ``` With this hack, it'll allow `Base.f` to work, which can make `override` check for class methods. Before this hack it'll not work due to this disparity. Since so far the only place we really need this is when we're checking `override` with those class methods, we don't have to take the risk to change how it works in production, but just how we check `override`. This hack is needed for `override` because we're checking `prepend` at where it's defined, not at where it's eventually included into a class, and that's where Concern does the magic. If one day we can stop using `ActiveSupport::Concern`, and just do plain old good Ruby, we'll be free from all those wild hacks. See original bug report: https://gitlab.com/gitlab-org/gitlab/-/issues/23932
-
Marcel Amirault authored
Docs: Clarify that filepath globs are Ruby globs (as opposed to shell or JavaScript globs). See merge request gitlab-org/gitlab!51818
-
David Hannasch authored
Bring rules:exists more in line with the robust documentation of cache:paths, but noting that rules:exists handles globs differently.
-
Albert Salim authored
Fix review app deployments See merge request gitlab-org/gitlab!52764
-
Kushal Pandya authored
Migrate feature flags page toggles to GlToggle See merge request gitlab-org/gitlab!52728
-
Coung Ngo authored
They are currently using the deprecated `vue_shared` toggle
-
Marcel Amirault authored
-
Evan Read authored
Update plan references for Fulfillment See merge request gitlab-org/gitlab!52635
-
Russell Dickenson authored
-
Evan Read authored
Changing Gold to Ultimate in user docs See merge request gitlab-org/gitlab!52846
-
Evan Read authored
Add client and developer documentation of the GraphQL API's limits See merge request gitlab-org/gitlab!52280
-
Luke Duncalfe authored
Adds client and developer documentation for the GraphQL API's limits: - Complexity - Max page size - Request timeout
-
Marcel Amirault authored
Define experiment feature flag type See merge request gitlab-org/gitlab!52855
-
Phil Calder authored
-
Kushal Pandya authored
Copy and empty %p fixes in Welcome page See merge request gitlab-org/gitlab!52660
-
Kevin Comoli authored
-
Ramya Authappan authored
Add QA docs for running transient bug tests See merge request gitlab-org/gitlab!52849
-
Ash McKenzie authored
Debian Group and Project Distribution Components See merge request gitlab-org/gitlab!51732
-
Russell Dickenson authored
Improve overriding stages example See merge request gitlab-org/gitlab!52808
-
Stan Hu authored
Group performance bar SQL queries by location See merge request gitlab-org/gitlab!52678
-
Russell Dickenson authored
Remove docs references to old subscription tiers See merge request gitlab-org/gitlab!52823
-
- 28 Jan, 2021 19 commits
-
-
Mark Lapierre authored
-
Mark Chao authored
Refactor spam/recaptcha mutations/services for better captcha support See merge request gitlab-org/gitlab!51537
-
Amy Qualls authored
Changing Gold to Ultimate in docs text See merge request gitlab-org/gitlab!52845
-
Nick Gaskill authored
Add visual reviews to starter list See merge request gitlab-org/gitlab!52848
-
Evan Read authored
Improve Service Desk documentation about templates See merge request gitlab-org/gitlab!51992
-
Marcin Sedlak-Jakubowski authored
-
Jose Ivan Vargas authored
Add recent failures to test report See merge request gitlab-org/gitlab!52606
-
Marcel Amirault authored
-
Chad Woolley authored
* Move the render_recaptcha? method to the Spammable concern, so it can be used from both the controllers and GraphQL mutations. * Refactor logic and method naming in mutation to make it explicit that the #resolve method's args parameter is being mutated before being passed to the service layer as params * Introduce ServiceCompatibility concern, to DRY up and abstract mutation-layer concerns related to processing graphql mutation field params to be compatible with those expected by the service layer * Rename SpammableMutationFields concern to CanMutateSpammable to be more consistently named with other concerns * Move and refactor the snippet_spam feature flag to be in the service layer, and be less coupled to the implementation details of spam checking. See https://gitlab.com/gitlab-org/gitlab/-/issues/217722 for more details.
-
Mark Lapierre authored
Fix delete action for package tests See merge request gitlab-org/gitlab!52718
-
Stan Hu authored
Resolve "Project name to path conversion in API mangles dots" See merge request gitlab-org/gitlab!52725
-
ngaskill authored
-
Russell Dickenson authored
Moved vulnerability report to separate docs page See merge request gitlab-org/gitlab!52749
-
Lindsay Kerr authored
Addressed duplication of vuln report section in security dashboard page
-
Scott Hampton authored
To abstract away from repeatedly accessing an object's property, we'll add that property to a computed prop so if we ever change that property name it's just one spot that we need to update.
-
ngaskill authored
-
Suzanne Selhorn authored
Remove Silver and Gold tiers from user docs See merge request gitlab-org/gitlab!52840
-
Amy Qualls authored
Add badges to H1 on Configure docs See merge request gitlab-org/gitlab!51526
-
Bob Van Landuyt authored
Add error handling to update member service See merge request gitlab-org/gitlab!52014
-