- 22 Jan, 2021 1 commit
-
-
Stan Hu authored
https://gitlab.com/gitlab-org/gitlab/-/merge_requests/48269 enabled LFS clients to use chunked transfers via `Transfer-Encoding: chunked`. However, in some cases, this breaks uploads to AWS S3 if specific-storage settings are used. We were able to reproduce this problem with Vagrant, but not with VMs on AWS or GCP. When direct uploads are used, GitLab will only generate pre-signed, multipart URLs if the `Content-Length` parameter is sent by the client. Previously when chunked transfers were not supported, this header was always available and thus was hard-coded in the LFS storage controller. When this header is no longer available, the Workhorse `BodyUploader` attempts to transfer the file with an S3 PutObject API call with `Transfer-Encoding: chunked`. This will return a `501 Not Implemented` error since this header is not supported; S3 has a different mechanism to chunked transfers. Note that Google Cloud Storage works fine in this manner. Now that `Content-Length` is not always available, we have a few options: 1. Disable LFS chunked transfers. 2. Re-enable request buffering in NGINX. 3. Modify Workhorse to tell us whether `Content-Length` was sent. 4. Be pessimistic and always generate multipart URLs and use a max length with the size of file. Option 1 is not optimal because we still want to support LFS chunked transfers, especially for GitLab.com where Cloudflare will reject files over 5 GB. Option 2 is not desirable either because it causes NGINX to store a large temporary file and delays the transfer to object storage. Option 3 is a slightly preferable option, but it involves modifying Workhorse as well. We should consider this as a follow-up issue. To fix the immediate problem, we implement option 4. Note that using consolidated object storage settings avoids this problem because Workhorse handles the upload natively with the AWS SDK and doesn't need presigned URLs. Relates to https://gitlab.com/gitlab-org/gitlab-workhorse/-/issues/292
-
- 21 Jan, 2021 39 commits
-
-
Amy Qualls authored
Move page to new location, update crosslinks See merge request gitlab-org/gitlab!52246
-
Andrew Fontaine authored
Pipeline Graph Structural Update: Small UI Fixes See merge request gitlab-org/gitlab!52251
-
Sarah Groff Hennigh-Palermo authored
-
Denys Mishunov authored
Update dependency @gitlab/ui to v26.1.0 See merge request gitlab-org/gitlab!52263
-
Amy Qualls authored
Monitor docs: add 'CORE' tier to page titles See merge request gitlab-org/gitlab!51523
-
Amy Qualls authored
Adds the CORE tier to the H1 on each page. While probably incorrect, this is a starting point for sending over to the PM for revision.
-
Stan Hu authored
Disable nakayoshi_fork by default in examples See merge request gitlab-org/gitlab!52209
-
Aleksei Lipniagov authored
-
Amy Qualls authored
Fix metadata capitalization See merge request gitlab-org/gitlab!52262
-
Russell Dickenson authored
Add docs how to fix flawfinder encoding errors See merge request gitlab-org/gitlab!51549
-
Daniel Paul Searles authored
-
Luke Duncalfe authored
Append `.` to description for GraphQL types derived from GlobalIDType See merge request gitlab-org/gitlab!52125
-
Mayra Cabrera authored
Merge branch '232536-feature-flag-enable-flag-for-the-configurable-defaults-for-squash-commits-option-feature' into 'master' Remove feature flag for "Squash commits" feature [RUN ALL RSPEC] [RUN AS-IF-FOSS] See merge request gitlab-org/gitlab!46498
-
Suzanne Selhorn authored
Added info about installing from group See merge request gitlab-org/gitlab!52034
-
Suzanne Selhorn authored
Related to: https://gitlab.com/gitlab-org/gitlab/-/issues/289939
-
Jose Ivan Vargas authored
No opener on Canary Link See merge request gitlab-org/gitlab!51708
-
Jannik Lehmann authored
-
Kerri Miller authored
BulkImports: Reduce memory consumption when importing Epics See merge request gitlab-org/gitlab!51595
-
Suzanne Selhorn authored
Minor update to Packages API docs See merge request gitlab-org/gitlab!52257
-
GitLab Bot authored
-
Craig Norris authored
Fix group/stage name in metadata.
-
Suzanne Selhorn authored
Updated to match matrix See merge request gitlab-org/gitlab!52037
-
Suzanne Selhorn authored
Related to: https://gitlab.com/gitlab-org/gitlab/-/issues/289937
-
Kerri Miller authored
Include submodule information for files in diff metadata See merge request gitlab-org/gitlab!50346
-
Andrew Fontaine authored
Fix breadcrumb dropdown on mobile being too narrow See merge request gitlab-org/gitlab!51092
-
Tim Rizzi authored
-
Stan Hu authored
Update hamlit to v2.14.2 See merge request gitlab-org/gitlab!52177
-
Robert Speicher authored
Allow Hiding Card in Billing Page for Current Deprecated Plans See merge request gitlab-org/gitlab!52039
-
Jason Goodman authored
Allows to hide cards for certain deprecated plans
-
Mike Jang authored
Improve Snowplow Ruby argument documentation See merge request gitlab-org/gitlab!51742
-
Mayra Cabrera authored
Allow versionless maven-metadata.xml file duplicates See merge request gitlab-org/gitlab!51758
-
Steve Abrams authored
When namespace_package_settings.maven_duplicates_allowed is set to false, allow the versionless maven-metadata.xml file to always be uploaded because it is added with every version update.
-
Amy Qualls authored
Updates the alert-notification page name to something shorter. Also updates two crosslinks to the page.
-
Gary Holtz authored
* It's been enabled by default for a while so it should be safe to remove at this point
-
Alishan Ladhani authored
Because they are outdated compared to the current implementation
-
Rémy Coutable authored
Remove feature flag yaml for whats new [RUN ALL RSPEC] [RUN AS IF FOSS] See merge request gitlab-org/gitlab!52234
-
Jose Ivan Vargas authored
Fix broken testsuite link if the suite contains a dot See merge request gitlab-org/gitlab!51828
-
Michael Aigner authored
-
Suzanne Selhorn authored
Added endpoint and duplicate info See merge request gitlab-org/gitlab!52027
-