- 19 Apr, 2022 40 commits
-
-
Toon Claes authored
Not all markdown fields are related to a project. Some, like those in Epics, might be related to a group. So in addition to finding the containing namespace through the project, also get try to get it from the group or namespace. Because we moved the responsibility of looking up the root namespace to the scope #for_resource in CustomEmoji, we can rely on that. This fixes custom emoji in Epic descriptions and notes. Changelog: fixed
-
Toon Claes authored
Custom Emoji is still behind a default-disabled feature flag [1]. With this change a few codepaths that weren't guarded by the feature flag are now disabled when the feature is not active. 1. https://gitlab.com/gitlab-org/gitlab/-/issues/231317
-
Toon Claes authored
Award Emoji can be awarded on many things and it can be difficult to determine which namespace the awardable belongs to. Thus to centralize the logic that finds the custom emoji for an awardable, we introduce a scope on the CustomEmoji model that accepts a resource (being either a Project or a Group), determines it's root namespace, and finds all CustomEmoji for it. In combination with the previous commit, all the Awardable models respond to #resource_parent, which can be provided to this new scope. This change fixes award emoji on merge requests, epics, and issues in nested groups. Changelog: fixed
-
Toon Claes authored
In a future commit we will be calling #resource_parent on an object we don't know the exact type of. But all of them respond to that method, except for Snippet. With this change we can safely call it without getting a NoMethodError.
-
Toon Claes authored
When we serialize the attributes of an awarded emoji, we ask the url of the emoji. This will only be set for Custom Emoji, and to find it, we need to look it up in the database. Now for built-in emoji, we know all the names of those, and we know they don't have an url set. So if the awarded emoji is one of the built-in, early return without ever querying the database. To ensure this behavior, and the method will not error-out, test coverage is added for AwardEmoji#url. Changelog: fixed
-
Matthias Käppler authored
Merge branch 'morefice/coverage-check-approval-rule-can-not-be-accessed-in-ee-premium' into 'master' Downgrade Coverage-check approval rule to EE Premium See merge request gitlab-org/gitlab!84290
-
Olena Horal-Koretska authored
Replace generic checkbox with GitLab UI styled checkbox See merge request gitlab-org/gitlab!85327
-
Simon Knox authored
Use pajamas checkbox for group owners can manage default branch checkbox See merge request gitlab-org/gitlab!84851
-
Fabio Pitino authored
Increase threshold limit for pipelines creation See merge request gitlab-org/gitlab!85373
-
Vasilii Iakliushin authored
Add prepend_mod to projects/graphs_controller.rb See merge request gitlab-org/gitlab!84866
-
Andreas Brandl authored
Add a new rubocop Database/DisableReferentialIntegrity See merge request gitlab-org/gitlab!85001
-
Marcia Ramos authored
Fix tense in background migration warning See merge request gitlab-org/gitlab!85338
-
Vasilii Iakliushin authored
Plumbing to allow blames to be limited or paginated See merge request gitlab-org/gitlab!84388
-
Nick Thomas authored
Changelog: changed
-
Phil Hughes authored
Terraform MR widget UI polish See merge request gitlab-org/gitlab!84627
-
Aleksei Lipniagov authored
Detect unsupported keyset queries with Prometheus See merge request gitlab-org/gitlab!85205
-
Albert Salim authored
Say load spec_helper first which is easier See merge request gitlab-org/gitlab!85367
-
Lin Jen-Shin authored
-
Shinya Maeda authored
Consolidate ProtectedEnvironment batch loading logic See merge request gitlab-org/gitlab!84802
-
Etienne Baqué authored
Add default scan execution policies stage to pipeline See merge request gitlab-org/gitlab!84640
-
Marius Bobin authored
-
Maxime Orefice authored
This commit allows to create coverage-check approval rule using gitlab premium plan. Changelog: changed EE: true
-
Natalia Tepluhina authored
VSA fix broken docs link See merge request gitlab-org/gitlab!85364
-
Ezekiel Kigbo authored
Adds additional jest tests for the VSA aggregating warning message
-
Fiona Neill authored
Remove ambiguous line from group permissions table See merge request gitlab-org/gitlab!85063
-
Evan Read authored
-
Jan Provaznik authored
Add `identifer` to response to pass as metric See merge request gitlab-org/gitlab!84990
-
Vitaly Slobodin authored
Migrate localization checkbox to gitlab-ui See merge request gitlab-org/gitlab!84765
-
Aleksei Lipniagov authored
Remove a comment mentioning a change to bot emails See merge request gitlab-org/gitlab!85334
-
Natalia Tepluhina authored
Remove jest test callbacks from specs (1/3) See merge request gitlab-org/gitlab!84479
-
Etienne Baqué authored
Update icon to long arrow See merge request gitlab-org/gitlab!85272
-
Jan Provaznik authored
Add a function to determine if a project is inactive See merge request gitlab-org/gitlab!84935
-
Jacques Erasmus authored
Migrate checkboxes to Pajamas form See merge request gitlab-org/gitlab!84757
-
Alex Pooley authored
Swap OncallRotations::BaseService to use ::BaseProjectService See merge request gitlab-org/gitlab!84656
-
Sarah Yasonik authored
Per developer style guides, we prefer to use a BaseContainerService class as the base class for any services.
-
Jacques Erasmus authored
Merge branch '323081-scrolling-to-the-bottom-of-the-user-profile-overview-page-triggers-the-infinite-scroll' into 'master' Fix infinite activities requests on profile See merge request gitlab-org/gitlab!84999
-
Adam Hegyi authored
Merge branch '357422-activerecord-querycanceled-pg-querycanceled-error-canceling-statement-due-to-statement' into 'master' Resolve "ActiveRecord::QueryCanceled: PG::QueryCanceled: ERROR: canceling statement due to statement timeout" See merge request gitlab-org/gitlab!84283
-
Gregory Havenga authored
Unscoping the where: :build_id scope from the cleanup_service scan_batch relation resolves a strange issue where this query was being carried through to the Security::Finding queries. `unscope` is not permitted for use outside of models, so this action was moved to a scope on the Security::Scan model. Changelog: performance MR: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/84283 EE: true
-
Jacques Erasmus authored
Merge branch '358363-replace-generic-checkbox-with-gitlab-ui-styled-checkbox-in-ee-app-views-admin' into 'master' Replace generic checkbox with GitLab UI styled checkbox in ee/app/views/admin/application_settings/_pseudonymizer.html.haml See merge request gitlab-org/gitlab!84883
-
Max Woolf authored
Fix order dependent cleanup package file worker spec See merge request gitlab-org/gitlab!85235
-