An error occurred fetching the project authors.
  1. 25 Sep, 2019 1 commit
  2. 25 Jul, 2019 2 commits
  3. 15 Apr, 2019 1 commit
  4. 31 Jan, 2019 1 commit
    • Stan Hu's avatar
      Alias GitHub and BitBucket OAuth2 callback URLs · 88f2e961
      Stan Hu authored
      To prevent an OAuth2 covert redirect vulnerability, this commit adds and
      uses an alias for the GitHub and BitBucket OAuth2 callback URLs to the
      following paths:
      
      GitHub: /users/auth/-/import/github
      Bitbucket: /users/auth/-/import/bitbucket
      
      This allows admins to put a more restrictive callback URL in the OAuth2
      configuration settings. Instead of https://example.com, admins can now use:
      
      https://example.com/users/auth
      
      It's possible but not trivial to change Devise and OmniAuth to use a
      different prefix for callback URLs instead of /users/auth. For now,
      aliasing the import URLs under the /users/auth namespace should suffice.
      
      Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/56663
      88f2e961
  5. 22 Jan, 2019 1 commit
    • Stan Hu's avatar
      Alias GitHub and BitBucket OAuth2 callback URLs · 6d57b2fd
      Stan Hu authored
      To prevent an OAuth2 covert redirect vulnerability, this commit adds and
      uses an alias for the GitHub and BitBucket OAuth2 callback URLs to the
      following paths:
      
      GitHub: /users/auth/-/import/github
      Bitbucket: /users/auth/-/import/bitbucket
      
      This allows admins to put a more restrictive callback URL in the OAuth2
      configuration settings. Instead of https://example.com, admins can now use:
      
      https://example.com/users/auth
      
      It's possible but not trivial to change Devise and OmniAuth to use a
      different prefix for callback URLs instead of /users/auth. For now,
      aliasing the import URLs under the /users/auth namespace should suffice.
      
      Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/56663
      6d57b2fd
  6. 18 Dec, 2018 2 commits
    • blackst0ne's avatar
      Update specs to rails5 format · 77b85029
      blackst0ne authored
      Updates specs to use new rails5 format.
      
      The old format:
      `get :show, { some: params }, { some: headers }`
      
      The new format:
      `get :show, params: { some: params }, headers: { some: headers }`
      77b85029
    • blackst0ne's avatar
      Update specs to rails5 format · b44a2c80
      blackst0ne authored
      Updates specs to use new rails5 format.
      
      The old format:
      `get :show, { some: params }, { some: headers }`
      
      The new format:
      `get :show, params: { some: params }, headers: { some: headers }`
      b44a2c80
  7. 23 Apr, 2018 2 commits
  8. 09 Feb, 2018 3 commits
  9. 02 Aug, 2017 2 commits
  10. 21 Jun, 2017 2 commits
  11. 24 May, 2017 3 commits
  12. 05 Apr, 2017 1 commit
  13. 21 Mar, 2017 1 commit
  14. 23 Feb, 2017 4 commits
  15. 25 Jan, 2017 1 commit
  16. 22 Nov, 2016 3 commits
  17. 31 Aug, 2016 1 commit
  18. 08 Jun, 2016 1 commit
  19. 23 Aug, 2015 1 commit
    • Stan Hu's avatar
      Remove user OAuth tokens stored in database for Bitbucket, GitHub, and GitLab · ed1d4fa4
      Stan Hu authored
      and request them each session. Pass these tokens to the project import data.
      
      This prevents the need to encrypt these tokens and clear them in case they
      expire or get revoked.
      
      For example, if you deleted and re-created OAuth2 keys for Bitbucket, you would get
      an Error 500 with no way to recover:
      
      ```
      Started GET "/import/bitbucket/status" for x.x.x.x at 2015-08-07 05:24:10 +0000
      Processing by Import::BitbucketController#status as HTML
      Completed 500 Internal Server Error in 607ms (ActiveRecord: 2.3ms)
      
      NameError (uninitialized constant Import::BitbucketController::Unauthorized):
        app/controllers/import/bitbucket_controller.rb:77:in `rescue in go_to_bitbucket_for_permissions'
        app/controllers/import/bitbucket_controller.rb:74:in `go_to_bitbucket_for_permissions'
        app/controllers/import/bitbucket_controller.rb:86:in `bitbucket_unauthorized'
      ```
      
      Closes #1871
      ed1d4fa4
  20. 07 Aug, 2015 1 commit
  21. 22 Jun, 2015 2 commits
  22. 01 Apr, 2015 1 commit
  23. 24 Feb, 2015 2 commits
  24. 12 Feb, 2015 1 commit