- 11 Aug, 2016 11 commits
-
-
Robert Speicher authored
Allow projects to be moved between repository storages ## What are the relevant issue numbers? Closes #759 See merge request !533
-
Alejandro Rodríguez authored
-
Alejandro Rodríguez authored
-
Rémy Coutable authored
Active tense test coverage This MR can be considered as a proper merge of https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5233 to EE /cc @tiagonbotelho See merge request !642
-
Valery Sizov authored
-
Valery Sizov authored
ES: Improve search performance by using parent/child relationships - [x] Indexing data with relations - [x] Using parent/child in queries - [x] Test everything - [x] Check if delete query should be routed as well. Documentation is not clear about this - [x] Resolve routing problem for Snippets. They not always has a parent project - [x] Specs Closes https://gitlab.com/gitlab-org/gitlab-ee/issues/375 See merge request !615
-
Valery Sizov authored
-
Valery Sizov authored
Bump gitlab-elasticsearch-git closes https://gitlab.com/gitlab-org/gitlab-ee/issues/832 See merge request !635
-
Valery Sizov authored
-
Valery Sizov authored
ES instrumenting /cc @pcarranza See merge request !638
-
Valery Sizov authored
-
- 10 Aug, 2016 6 commits
-
-
Valery Sizov authored
Removed geo_node_key_id index This index does not appear to be used, see https://gitlab.com/gitlab-org/gitlab-ce/issues/20767 for more information. cc @brodock See merge request !639
-
Rémy Coutable authored
Signed-off-by: Rémy Coutable <remy@rymai.me>
-
Yorick Peterse authored
This index is not used by PostgreSQL and it appears the code never filters using this column either. See https://gitlab.com/gitlab-org/gitlab-ce/issues/20767 for more information.
-
Rémy Coutable authored
Used cached value of project count to reduce DB load Requires gitlab-org/gitlab-ce!5746 Possible fix for gitlab-com/infrastructure#303 See merge request !637
-
Rémy Coutable authored
Signed-off-by: Rémy Coutable <remy@rymai.me>
-
Stan Hu authored
Requires gitlab-org/gitlab-ce!5746 Possible fix for gitlab-com/infrastructure#303
-
- 09 Aug, 2016 8 commits
-
-
Robert Speicher authored
Fix Contribution Analytics and move test to RSpec. Apparently Spinach tests don't fail when there are JS errors, which is why this didn't get caught earlier. Changing the test to RSpec should future-proof it. Fixes #871. See merge request !633
-
Connor Shea authored
-
Rémy Coutable authored
Active tense coverage MR made for compatibility with CE according to the Merge Request (https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5233) See merge request !621
-
Connor Shea authored
Apparently Spinach tests don't fail when there are JS errors, which is why this didn't get caught earlier. This should future-proof it. Fix #871.
-
Stan Hu authored
Remove blank line in DB migration to fix Rubocop error See merge request !634
-
tiagonbotelho authored
-
Stan Hu authored
-
tiagonbotelho authored
-
- 08 Aug, 2016 15 commits
-
-
Robert Speicher authored
Replace LDAP exclusive lease with state machine Part 1 from https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/500 This only replaces the exclusive lease with a state machine. There needs to be a bit more work to support the single group syncing after this, but it paves the way. Replacing the lease will also help support a lot! See merge request !565
-
Valery Sizov authored
CE upstream See merge request !629
-
Ruben Davila authored
-
Valery Sizov authored
-
Douwe Maan authored
Enable Style/EmptyLinesAround Module/Class Body cop ## What does this MR do? Enable a new rubocop cops as discussed here: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/1877/diffs#note_13021078 ## Are there points in the code the reviewer needs to double check? May be a good idea to send a message to people to prevent `master` red because of the new cop. ## Why was this MR needed? We want to improve code style and not waste endbosses time checking style manually ## What are the relevant issue numbers? ## Screenshots (if relevant) ## Does this MR meet the acceptance criteria? - [ ] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added - [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md) - [ ] API support added - Tests - [ ] Added for this feature/bug - [ ] All builds are passing - [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides) - [ ] Branch has no merge conflicts with `master` (if you do - rebase it please) - [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits) See merge request !5692
-
Douwe Maan authored
Revert "Defend against 'Host' header injection" We reverted this in omnibus but forgot to do it in the source NGINX template. See merge request !5706
-
Douwe Maan authored
Enable Style/SpaceAroundEqualsInParameterDefault cop ## What does this MR do? Enable a new rubocop cops as discussed here: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/1877#note_13529646 ## Are there points in the code the reviewer needs to double check? May be a good idea to send a message to people to prevent master red because of the new cop. ## Why was this MR needed? We want to improve code style and not waste endbosses time checking style manually ## What are the relevant issue numbers? ## Screenshots (if relevant) ## Does this MR meet the acceptance criteria? - [ ] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added - [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md) - [ ] API support added - Tests - [ ] Added for this feature/bug - [ ] All builds are passing - [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides) - [ ] Branch has no merge conflicts with `master` (if you do - rebase it please) - [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits) See merge request !5693
-
Douwe Maan authored
Log base64-decoded PostReceive arguments The change to base64-encoding the third argument to PostReceive in gitlab-shell made our Sidekiq ArgumentsLogger a little less useful. This change adds decoded data to the log statement. Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/20381 See merge request !5547
-
Rémy Coutable authored
Support pending invitation project members importing projects Adds support for pending invitation project members on Import/Export - previously the import would fail. Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/19973 - [x] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added - Tests - [x] Added for this feature/bug - [x] All builds are passing - [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides) - [x] Branch has no merge conflicts with `master` (if you do - rebase it please) - [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits) See merge request !5683
-
Rémy Coutable authored
Optimize "cache_key" using a concern ## What does this MR do? This MR adds a concern (used by Issue and Note) that provides an optimized version of Rails' `cache_key` method. See 77c8520e for more details. ## Are there points in the code the reviewer needs to double check? No, though a spell check would be appreciated. ## Why was this MR needed? When loading a lot of data from Redis (e.g. an issue with lots of notes) quite a large amount of time is spent in generating cache keys. This is due to multiple reasons such as: * Rails trying to figure out if it should use `updated_at` or `updated_on` using somewhat inefficient code * Rails relying on pluralization logic to figure out how to generate a cache namespace using a model name * Rails calling a whole bunch of methods in general in the process of generating cache keys In short, Rails is trying to cater to every possible use case, at the cost of performance. ## What are the relevant issue numbers? https://gitlab.com/gitlab-org/gitlab-ce/issues/13651 is not directly related but I ran into this `cache_key` problem when looking into said issue. See merge request !5715
-
James Lopez authored
-
Rémy Coutable authored
Update templates There was a copy pasta in the templates, therefor another MR with updates. See merge request !5714
-
Dmitriy Zaporozhets authored
-
Yorick Peterse authored
This concern provides an optimized/simplified version of the "cache_key" method. This method is about 9 times faster than the default "cache_key" method. The produced cache keys _are_ different from the previous ones but this is worth the performance improvement. To showcase this I set up a benchmark (using benchmark-ips) that compares FasterCacheKeys#cache_key with the regular cache_key. The output of this benchmark was: Calculating ------------------------------------- cache_key 4.825k i/100ms cache_key_fast 21.723k i/100ms ------------------------------------------------- cache_key 59.422k (± 7.2%) i/s - 299.150k cache_key_fast 543.243k (± 9.2%) i/s - 2.694M Comparison: cache_key_fast: 543243.4 i/s cache_key: 59422.0 i/s - 9.14x slower To see the impact on real code I applied these changes and benchmarked Issue#referenced_merge_requests. For an issue referencing 10 merge requests these changes shaved off between 40 and 60 milliseconds.
-
Z.J. van de Weg authored
-