- 08 Feb, 2021 22 commits
-
-
Patrick Steinhardt authored
In order to check whether certain operations are allowed to be executed by a user, Gitaly POSTs to the `/internal/allowed` endpoint. The request includes information about what change the user wants to perform, but it also contains information about the environment the change is currently performed in. When a user performs a push, git will first store all pushed objects into a quarantine environment. This is a separate temporary directory containing all new objects such that if the push gets rejected, new objects will not persist in the repository. The crux is that in order to inspect these new objects, git needs to be told that such a quarantine environment exists. This is why Gitaly sends information about this quarantine environment to `/internal/allowed`, so that we can again relay this information back to Gitaly when we want to inspect newly pushed objects to determine whether they're allowed or not. While it's a leaky abstraction, it has worked fine until now. But with transactions, that's not true anymore: when multiple Gitaly nodes take part in a push, then they'll all generate a randomly named quarantine environment. But as only the primary node will inject its info into the request, we are not able to acces quarantine environments of secondary nodes. If we now route accessor requests to any of the secondary Gitaly nodes with the quarantine environment of the primary, then the request will fail as git cannot find quarantined objects. To fix this, Gitaly has recently grown a new GRPC header which allows us to force-route requests to the primary via 1102b0b67 (praefect: Implement force-routing to primary for node-manager router, 2021-02-03) and 4d877d7d5 (praefect: Implement force-routing to primary for per-repo router, 2021-02-03). So let's set that header if we know that we're being executed via a hook, which is the only case where a quarantine environment may exist.
-
Natalia Tepluhina authored
Resolve "[Jobs empty state] Successful Cleanup" [RUN ALL RSPEC] [RUN AS-IF-FOSS] See merge request gitlab-org/gitlab!53240
-
Matthias Käppler authored
Revert '290944-pull-by-digest' and cleanup bad records See merge request gitlab-org/gitlab!53506
-
Jan Provaznik authored
Send only latest jobs in pipeline webhook payload See merge request gitlab-org/gitlab!53159
-
Ash McKenzie authored
Debian Publications See merge request gitlab-org/gitlab!52916
-
Sanad Liaquat authored
Reduce duplication of QA custom matchers See merge request gitlab-org/gitlab!52721
-
charlie ablett authored
Merge branch '300913-refactor-group_sso-and-group_managed_account-entity-properties-to-use-presenter' into 'master' Refactor member entity properties to use presenter See merge request gitlab-org/gitlab!53276
-
Mathieu Parent authored
-
Albert Salim authored
Also hint that dev pipelines should be checked See merge request gitlab-org/gitlab!53452
-
Albert Salim authored
Fail Dangerbot if metrics dictionary.md is not updated See merge request gitlab-org/gitlab!53397
-
Albert Salim authored
Merge branch '301209-post-an-information-message-about-automatic-update-of-mr-title-when-the-mr-adds-removes-a' into 'master' Post an information message about automatic update of MR title when the MR adds/removes a feature flag [RUN ALL RSPEC] [RUN AS-IF-FOSS] See merge request gitlab-org/gitlab!53513
-
Lin Jen-Shin authored
-
alinamihaila authored
Use all_changed_files Rubocop:disable Style/SignalException
-
Rémy Coutable authored
Signed-off-by: Rémy Coutable <remy@rymai.me>
-
Evan Read authored
Update codeowners with docs directories See merge request gitlab-org/gitlab!53569
-
Marcel Amirault authored
As many directories to make sure the correct TWs are pinged by GitLab bot on community contributions
-
Kushal Pandya authored
Add custom scanners to vulnerability list scanner filter [RUN ALL RSPEC] [RUN AS-IF-FOSS] See merge request gitlab-org/gitlab!49710
-
Daniel Tian authored
Add custom scanners to scanner filter dropdown on vulnerability report
-
Kushal Pandya authored
Add btn-default to buttons in todos page See merge request gitlab-org/gitlab!53348
-
Yogi authored
-
Russell Dickenson authored
Add subscriptions endpoint See merge request gitlab-org/gitlab!53184
-
Cynthia Ng authored
-
- 07 Feb, 2021 5 commits
-
-
Russell Dickenson authored
docs: Add SAST analyzer section on post analyzers See merge request gitlab-org/gitlab!53505
-
Lucas Charles authored
-
Russell Dickenson authored
Unchecked mark was not rendering on windows See merge request gitlab-org/gitlab!53349
-
Thong Kuah authored
[RUN ALL RSPEC] Update grape gem to 1.5.2 See merge request gitlab-org/gitlab!53547
-
Savas Vedova authored
Cleanup onboarding issues experiment [RUN ALL RSPEC] [RUN AS-IF-FOSS] See merge request gitlab-org/gitlab!52905
-
- 06 Feb, 2021 13 commits
-
-
Kerri Miller authored
Route alert management docs urls to helpful locations See merge request gitlab-org/gitlab!51665
-
Matija Čupić authored
-
Matija Čupić authored
-
Matija Čupić authored
-
Peter Leitzen authored
Remove unused methods See merge request gitlab-org/gitlab!53520
-
Igor Drozdov authored
Fixes Ruby 2.7 warnings CHANGELOG: https://github.com/ruby-grape/grape/blob/master/CHANGELOG.md
-
Enrique Alcántara authored
Update dependency @gitlab/ui to v27.4.6 See merge request gitlab-org/gitlab!53503
-
Natalia Tepluhina authored
Fix eslint error to make the master green See merge request gitlab-org/gitlab!53543
-
Vitaly Slobodin authored
-
Kamil Trzciński authored
Remove the project label from histogram metrics See merge request gitlab-org/gitlab!53496
-
Paul Slaughter authored
Fix "Stay on Page" alert showing in empty snippet See merge request gitlab-org/gitlab!50400
-
-
Paul Slaughter authored
Remove fuzzy search for emoji See merge request gitlab-org/gitlab!51972
-