1. 16 Dec, 2018 11 commits
    • Thong Kuah's avatar
      Use finder to decide to show note to user · f82c9dbe
      Thong Kuah authored
      Given the note is about how to interpret ancestor clusters, use the
      finder which actually knows if there are any ancestor clusters to find
      out if the note should be shown, rather than passing the same info via a
      view to a helper
      
      Added note about Kaminari.paginate_array
      
      Link to followup issue too
      f82c9dbe
    • Thong Kuah's avatar
      Check can :read_clusters in finder · 2ad5f999
      Thong Kuah authored
      This is in addtion to the can checks we have in the controller, as a
      finder can be used elsewhere in the future.
      2ad5f999
    • Thong Kuah's avatar
      Move code to presenter · 0e78834b
      Thong Kuah authored
      Part of the code such as #show_path is already present on the presenter.
      Also avoid having code in two places (helper and presenter)
      
      Sanitize and assert html_safe. Additional layer of defense - on top of
      GitLab already requiring group names to be composed of small set of
      chars A-Z, - and spaces.
      
      Only link to cluster if user can read cluster
      
      Make clear that arg is a GroupClusterablePresenter
      
      Add more specs for completeness
      0e78834b
    • Mayra Cabrera's avatar
      Refactor methods on ClusterHelper · 0369e759
      Mayra Cabrera authored
      - Use sprite_icon instead of hardcoded html
      - Use a more descriptive method name
      - Changes specs to use html_safe matcher
      0369e759
    • Mayra Cabrera's avatar
      Cleans cluster views a bit · aa86223a
      Mayra Cabrera authored
      - Moves logic into ClustersHelp
      - Add CSS to ensure compatibility with EE view.
      aa86223a
    • Thong Kuah's avatar
      Move group path display logic to helper · 9dc67bf1
      Thong Kuah authored
      Add specs
      9dc67bf1
    • Mike Greiling's avatar
      Update link to documentation · 887bbd8e
      Mike Greiling authored
      Make link clear in note box
      
      Also update strings to be translatable
      887bbd8e
    • Mike Greiling's avatar
      Render group namespaces in clusters index · 671c5b2e
      Mike Greiling authored
      671c5b2e
    • Mike Greiling's avatar
      bfec22a0
    • Thong Kuah's avatar
      Show clusters of ancestors in cluster list page · 7e4f76ea
      Thong Kuah authored
      Show both the cluster(s) of the clusterable, and the cluster(s) of
      ancestor groups.
      7e4f76ea
    • Stan Hu's avatar
      Merge branch... · 8b460204
      Stan Hu authored
      Merge branch '55402-broken-master-karma-test-failing-in-spec-javascripts-boards-components-issue_due_date_spec-js' into 'master'
      
      Resolve "Broken master: karma test failing in spec/javascripts/boards/components/issue_due_date_spec.js"
      
      Closes #55402
      
      See merge request gitlab-org/gitlab-ce!23845
      8b460204
  2. 15 Dec, 2018 3 commits
  3. 14 Dec, 2018 26 commits