- 16 Dec, 2018 11 commits
-
-
Thong Kuah authored
Given the note is about how to interpret ancestor clusters, use the finder which actually knows if there are any ancestor clusters to find out if the note should be shown, rather than passing the same info via a view to a helper Added note about Kaminari.paginate_array Link to followup issue too
-
Thong Kuah authored
This is in addtion to the can checks we have in the controller, as a finder can be used elsewhere in the future.
-
Thong Kuah authored
Part of the code such as #show_path is already present on the presenter. Also avoid having code in two places (helper and presenter) Sanitize and assert html_safe. Additional layer of defense - on top of GitLab already requiring group names to be composed of small set of chars A-Z, - and spaces. Only link to cluster if user can read cluster Make clear that arg is a GroupClusterablePresenter Add more specs for completeness
-
Mayra Cabrera authored
- Use sprite_icon instead of hardcoded html - Use a more descriptive method name - Changes specs to use html_safe matcher
-
Mayra Cabrera authored
- Moves logic into ClustersHelp - Add CSS to ensure compatibility with EE view.
-
Thong Kuah authored
Add specs
-
Mike Greiling authored
Make link clear in note box Also update strings to be translatable
-
Mike Greiling authored
-
Mike Greiling authored
-
Thong Kuah authored
Show both the cluster(s) of the clusterable, and the cluster(s) of ancestor groups.
-
Stan Hu authored
Merge branch '55402-broken-master-karma-test-failing-in-spec-javascripts-boards-components-issue_due_date_spec-js' into 'master' Resolve "Broken master: karma test failing in spec/javascripts/boards/components/issue_due_date_spec.js" Closes #55402 See merge request gitlab-org/gitlab-ce!23845
-
- 15 Dec, 2018 3 commits
-
-
Nick Thomas authored
Display empty files properly on MR diffs Closes #54786 See merge request gitlab-org/gitlab-ce!23671
-
Martin Wortschack authored
-
Stan Hu authored
Resolve transient failure in Help page spec Closes #55372 See merge request gitlab-org/gitlab-ce!23839
-
- 14 Dec, 2018 26 commits
-
-
Mike Greiling authored
Resolve "Merge button does not appear after Rebase-ing" Closes #47052 See merge request gitlab-org/gitlab-ce!23572
-
Achilleas Pipinellis authored
Fixed link in doc/ci/yaml/README.md See merge request gitlab-org/gitlab-ce!23433
-
Achilleas Pipinellis authored
Refactor the only and except complex section See merge request gitlab-org/gitlab-ce!23792
-
Achilleas Pipinellis authored
Docs: Let's Encrypt certificate for GitLab Pages Closes #51979 See merge request gitlab-org/gitlab-ce!23777
-
Marcia Ramos authored
-
Stan Hu authored
Removed rails 5 documentation See merge request gitlab-org/gitlab-ce!23840
-
Stan Hu authored
Remove Rails 4 support See merge request gitlab-org/gitlab-ce!23717
-
Stan Hu authored
Resolve a transient failure in MWPS feature spec Closes gitlab-ee#6770 See merge request gitlab-org/gitlab-ce!23838
-
Robert Speicher authored
Sometimes due to a slow request to load the version check image, the placeholder image data was still being seen, resulting in this failure: expected "data:image/gif;base64,R0lGODlhAQABAAAAACH5BAEKAAEALAAAAAABAAEAAAICTAEAOw==" to end with "/version-check-url" Now we check the `data-src` attribute, which allows us to remove the `:js` metadata. This commit also removes a redundant test, which was just ensuring that the selector we were already using in the other test is visible. If this test were failing, the other one would always fail too, so it was pointless. Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/55372
-
Robert Speicher authored
All of these methods are stateless, there was no point to have them as instance methods. Mostly this allows us to remove an `allow_any_instance_of` usage.
-
Jasper Maes authored
-
Jan Provaznik authored
Because we removed rails 4 support, this document is not needed anymore.
-
Stan Hu authored
Remove CREATE_DB_USER variable in prepare_build See merge request gitlab-org/gitlab-ce!23815
-
Filipa Lacerda authored
Update prettier.md with VSCode Settings section See merge request gitlab-org/gitlab-ce!23810
-
Robert Speicher authored
When this spec is run in a certain order, there appeared to be a timing issue with opening the "Merge when pipeline succeeds" drop-down menu. We now explicitly wait for any pending requests to complete before clicking the drop-down. Closes https://gitlab.com/gitlab-org/gitlab-ee/issues/6770
-
Robert Speicher authored
Fix warnings in tests See merge request gitlab-org/gitlab-ce!23788
-
Kamil Trzciński authored
Refactor Ci::Pipeline's config_sources enum Closes gitlab-ee#8244 See merge request gitlab-org/gitlab-ce!23799
-
Kamil Trzciński authored
Move description of cluster type to presenter Closes #53771 See merge request gitlab-org/gitlab-ce!23789
-
Douwe Maan authored
Remove issue_suggestions feature flag Closes #55166 See merge request gitlab-org/gitlab-ce!23723
-
Sam Bigelow authored
Update changelog to include Merge Request ID and Author Update changelog to include Merge Request ID and Author
-
Paul Slaughter authored
**Why?** This is a recurring issue that new team members keep running into.
-
Achilleas Pipinellis authored
doc/ci/yaml: improve wording to explain better deep vs recursive merging See merge request gitlab-org/gitlab-ce!22542
-
Achilleas Pipinellis authored
Serverless Doc Updates Closes #55089 See merge request gitlab-org/gitlab-ce!23640
-
Daniel Gruesso authored
-
Bob Van Landuyt authored
All arguments passed to the `FeatureConstrainer` will be passed on to the `Feature.enabled?` check.
-
Achilleas Pipinellis authored
Add dplanella as Catalan proofreader See merge request gitlab-org/gitlab-ce!23827
-