Merge branch 'sh-fix-circular-dependency-errors' into 'master'

Remove circular dependency between HTTPHelper and GitlabNet

Closes #169

See merge request gitlab-org/gitlab-shell!258

lib/gitlab_net.rb

@@ -10,9 +10,6 @@ require_relative 'http_helper'
 class GitlabNet # rubocop:disable Metrics/ClassLength
   include HTTPHelper
 
-  class ApiUnreachableError < StandardError; end
-  class NotFound < StandardError; end
-
   CHECK_TIMEOUT = 5
   API_INACCESSIBLE_MESSAGE = 'API is not accessible'.freeze
 

lib/gitlab_net/errors.rb

+class GitlabNet
+  class ApiUnreachableError < StandardError; end
+  class NotFound < StandardError; end
+end

lib/http_helper.rb

 require_relative 'httpunix'
 require_relative 'gitlab_logger'
+require_relative 'gitlab_net/errors'
 
 module HTTPHelper
   READ_TIMEOUT = 300