Merge branch 'remove-gitaly-proto-helper' into 'master'

Remove unused vendored code

See merge request gitlab-org/gitlab-shell!265

go/vendor/gitlab.com/gitlab-org/gitaly-proto/go/helper/inforefs.go

-package helper
-
-import (
-	"io"
-
-	pb "gitlab.com/gitlab-org/gitaly-proto/go"
-)
-
-type InfoRefsClient interface {
-	Recv() (*pb.InfoRefsResponse, error)
-}
-
-type InfoRefsClientWriterTo struct {
-	InfoRefsClient
-}
-
-func (clientReader *InfoRefsClientWriterTo) WriteTo(w io.Writer) (total int64, err error) {
-	for {
-		response, err := clientReader.Recv()
-		if err == io.EOF {
-			return total, nil
-		} else if err != nil {
-			return total, err
-		}
-
-		n, err := w.Write(response.GetData())
-		total += int64(n)
-		if err != nil {
-			return total, err
-		}
-	}
-}

go/vendor/gitlab.com/gitlab-org/gitaly-proto/go/helper/stream.go

-package helper
-
-import (
-	"io"
-)
-
-// NewReceiveReader turns receiver into an io.Reader. Errors from the
-// receiver function are passed on unmodified. This means receiver should
-// emit io.EOF when done.
-func NewReceiveReader(receiver func() ([]byte, error)) io.Reader {
-	return &receiveReader{receiver: receiver}
-}
-
-type receiveReader struct {
-	receiver func() ([]byte, error)
-	data     []byte
-	err      error
-}
-
-func (rr *receiveReader) Read(p []byte) (int, error) {
-	if len(rr.data) == 0 {
-		rr.data, rr.err = rr.receiver()
-	}
-	n := copy(p, rr.data)
-	rr.data = rr.data[n:]
-	if len(rr.data) == 0 {
-		return n, rr.err
-	}
-	return n, nil
-}
-
-// NewSendWriter turns sender into an io.Writer. The number of 'bytes
-// written' reported back is always len(p).
-func NewSendWriter(sender func(p []byte) error) io.Writer {
-	return &sendWriter{sender: sender}
-}
-
-type sendWriter struct {
-	sender func([]byte) error
-}
-
-func (sw *sendWriter) Write(p []byte) (int, error) {
-	return len(p), sw.sender(p)
-}

go/vendor/vendor.json

@@ -76,14 +76,6 @@
 			"version": "v1.3.0",
 			"versionExact": "v1.3.0"
 		},
-		{
-			"checksumSHA1": "GkeSZfXVbtAkBZOrswot19GJZqQ=",
-			"path": "gitlab.com/gitlab-org/gitaly-proto/go/helper",
-			"revision": "ca09ca1e2da6dc957644fa95990e8a3d032d6252",
-			"revisionTime": "2018-11-28T10:00:28Z",
-			"version": "v1.3.0",
-			"versionExact": "v1.3.0"
-		},
 		{
 			"checksumSHA1": "oUtVvP0F/NLt9fen+qUoOnfQHv0=",
 			"path": "gitlab.com/gitlab-org/gitaly/auth",