Properly rescue from JSON parse.

3c9ef9eb · Patricio Cano · a070ae4a · 3c9ef9eb
Commit 3c9ef9eb authored Sep 08, 2016 by Patricio Cano
Hide whitespace changes
Inline Side-by-side

Showing with 6 additions and 2 deletions

lib/gitlab_lfs_authentication.rb lib/gitlab_lfs_authentication.rb +6 -2

No files found.
--- a/lib/gitlab_lfs_authentication.rb
+++ b/lib/gitlab_lfs_authentication.rb
@@ -11,8 +11,12 @@ class GitlabLfsAuthentication
  end
  def self.build_from_json(json)
-    values = JSON.parse(json) rescue nil
+    begin
-    self.new(values['username'], values['lfs_token'], values['repository_http_path'])
+      values = JSON.parse(json)
+      self.new(values['username'], values['lfs_token'], values['repository_http_path'])
+    rescue
+      nil
+    end
  end
  def authentication_payload