Merge branch '21451-change-merge-request-text-after-pushing-new-branch' into 'master'

Make merge request text after push clearer

The message to create a merge request after pushing a new branch was not clear. It is now clear that it is optional to create a merge request for the pushed branch.

Part of [#21451](https://gitlab.com/gitlab-org/gitlab-ce/issues/21451)

See merge request !109

CHANGELOG

 v4.1.0
   - Add support for global custom hooks and chained hook directories (Elan Ruusamäe, Dirk Hörner), !93, !89, #32
+  - Clear up text with merge request after new branch push (Lisanne Fellinger)
 
 v4.0.3
   - Fetch repositories with `--prune` option by default

lib/gitlab_post_receive.rb

@@ -56,7 +56,7 @@ class GitlabPostReceive
 
   def print_merge_request_link(merge_request)
     if merge_request["new_merge_request"]
-      message = "Create merge request for #{merge_request["branch_name"]}:"
+      message = "To create a merge request for #{merge_request["branch_name"]}, visit:"
     else
       message = "View merge request for #{merge_request["branch_name"]}:"
     end

spec/gitlab_post_receive_spec.rb

@@ -49,7 +49,7 @@ describe GitlabPostReceive do
 
           expect(gitlab_post_receive).to receive(:puts).ordered
           expect(gitlab_post_receive).to receive(:puts).with(
-            "Create merge request for new_branch:"
+            "To create a merge request for new_branch, visit:"
           ).ordered
           expect(gitlab_post_receive).to receive(:puts).with(
             "  http://localhost/dzaporozhets/gitlab-ci/merge_requests/new?merge_request%5Bsource_branch%5D=new_branch"
@@ -123,7 +123,7 @@ describe GitlabPostReceive do
 
         expect(gitlab_post_receive).to receive(:puts).ordered
         expect(gitlab_post_receive).to receive(:puts).with(
-          "Create merge request for new_branch:"
+          "To create a merge request for new_branch, visit:"
         ).ordered
         expect(gitlab_post_receive).to receive(:puts).with(
           "  http://localhost/dzaporozhets/gitlab-ci/merge_requests/new?merge_request%5Bsource_branch%5D=new_branch"