Merge branch 'ash.mckenzie/allowed-api-proper-http-status-code-support' into 'master'

Proper HTTP status code support for /api/v4/allowed API endpoint

Closes gitlab-ce#51211

See merge request gitlab-org/gitlab-shell!237

lib/gitlab_net.rb

@@ -35,7 +35,8 @@ class GitlabNet # rubocop:disable Metrics/ClassLength
     url = "#{internal_api_endpoint}/allowed"
     resp = post(url, params)
 
-    if resp.code == '200'
+    case resp.code.to_s
+    when HTTP_SUCCESS, HTTP_UNAUTHORIZED, HTTP_NOT_FOUND
       GitAccessStatus.create_from_json(resp.body)
     else
       GitAccessStatus.new(false,

lib/http_codes.rb

+module HTTPCodes
+  HTTP_SUCCESS = '200'.freeze
+  HTTP_UNAUTHORIZED = '401'.freeze
+  HTTP_NOT_FOUND = '404'.freeze
+end

lib/http_helper.rb

+require_relative 'http_codes'
+
 module HTTPHelper
+  include HTTPCodes
+
   READ_TIMEOUT = 300
 
   protected