1. 08 Apr, 2016 1 commit
    • Kirill Smelkov's avatar
      There is no need to keep old hooks around - remove them · 03df9d7f
      Kirill Smelkov authored
      [ Sent upstream: https://gitlab.com/gitlab-org/gitlab-shell/merge_requests/40
      
        This was filed upstream but decided the better way to go is to
        configure default git templates to be just empty.
      
        Until we implement that, we continue to carry this patch as NXD ]
      
      gitlab-shell uses completely own whole set of git hooks and just
      symlinks repo.git/hooks to path/to/gitlab-shell/hooks/.
      
      Original hooks that git added there - when initializing repository -
      from its template, and which are by default deactivated, are currently
      moved to repos.git/hooks.old.<timestamp>, e.g.
      
      $ ls -F nexedi/helloweb.git/
          config
          description
          HEAD
          hooks@                  -->  ...path/to/gitlab-shell/hooks/
          hooks.old.1446564288/
          info/
          packed-refs
          refs/
      
      $ ls -F nexedi/helloweb.git/hooks.old.1446564288/
          applypatch-msg.sample*
          post-update.sample*
          pre-commit.sample*
          pre-push.sample*
          update.sample*
          commit-msg.sample*
          pre-applypatch.sample*
          prepare-commit-msg.sample*
          pre-rebase.sample*
      
      On the other hand, hooks.old.<timestamp> are not used anywhere and are
      left there "just in case". But what is the point to keep those pristine
      samples git creates by default? And we are sure those files are always
      results of gitlab-shell initializing a repository, as it is
      gitlab-shell's job to create/remove/update/etc repositories.
      
      So do not keep old hooks, remove them.
      
      P.S. The patch that introduced whole-hooks-dir-symlinking is
          db81327b (Symlink the whole hooks directory).
      
      /cc @dzaporozhets, @jacobvosmaer
      03df9d7f
  2. 18 Mar, 2016 2 commits
  3. 16 Mar, 2016 3 commits
  4. 14 Mar, 2016 2 commits
  5. 08 Mar, 2016 1 commit
  6. 03 Mar, 2016 3 commits
  7. 10 Feb, 2016 5 commits
  8. 09 Feb, 2016 7 commits
  9. 05 Jan, 2016 1 commit
  10. 04 Jan, 2016 2 commits
  11. 14 Dec, 2015 2 commits
  12. 11 Dec, 2015 2 commits
  13. 01 Dec, 2015 1 commit
  14. 26 Nov, 2015 1 commit
  15. 25 Nov, 2015 7 commits