Do not restrict listen socket access by default

Closes https://gitlab.com/gitlab-org/gitlab-workhorse/issues/33

CHANGELOG

@@ -2,6 +2,11 @@
 
 Formerly known as 'gitlab-git-http-server'.
 
+v0.7.3 (unreleased)
+
+Revert 'buffer Git HTTP responses'. Set default listen socket
+permissions to world read/writeable.
+
 v0.7.2 DO NOT USE
 
 Integrate with GOPATH during development (remove relative imports

README.md

@@ -24,7 +24,7 @@ Options:
   -listenNetwork string
     	Listen 'network' (tcp, tcp4, tcp6, unix) (default "tcp")
   -listenUmask int
-    	Umask for Unix socket, default: 022 (default 18)
+    	Umask for Unix socket (default 0)
   -pprofListenAddr string
     	pprof listening address, e.g. 'localhost:6060'
   -proxyHeadersTimeout duration

main.go

@@ -33,7 +33,7 @@ var Version = "(unknown version)" // Set at build time in the Makefile
 var printVersion = flag.Bool("version", false, "Print version and exit")
 var listenAddr = flag.String("listenAddr", "localhost:8181", "Listen address for HTTP server")
 var listenNetwork = flag.String("listenNetwork", "tcp", "Listen 'network' (tcp, tcp4, tcp6, unix)")
-var listenUmask = flag.Int("listenUmask", 022, "Umask for Unix socket, default: 022")
+var listenUmask = flag.Int("listenUmask", 0, "Umask for Unix socket")
 var authBackend = URLFlag("authBackend", upstream.DefaultBackend, "Authentication/authorization backend")
 var authSocket = flag.String("authSocket", "", "Optional: Unix domain socket to dial authBackend at")
 var pprofListenAddr = flag.String("pprofListenAddr", "", "pprof listening address, e.g. 'localhost:6060'")