Skip to content

G
gitlab-workhorse
Switch branch/tag
  1. 04 Sep, 2018 1 commit
    • Stan Hu's avatar
      Support adding PUT headers for object storage from Rails · 7231f85e
      Stan Hu authored 
      As revealed in https://gitlab.com/gitlab-org/gitlab-ce/issues/49957, Rails
generates a signed URL with a fixed HTTP header with `Content-Type:
application/octet-stream`. However, if we change or remove that for
some reason in Workhorse, this breaks the upload with a 403 Unauthorized because
the signed URL is not valid.

We can make this more robust by doing the following:

1. In the `/uploads/authorize` request, Rails can return a `StoreHeaders` key-value
pair in the JSON response containing the required headers that the PUT
request must include.
2. Use those HTTP headers if that value is present.
3. For backwards compatibility, if that key is not present, default to
the old behavior of sending the fixed `Content-Type` header.
      7231f85e
  3. 17 Aug, 2018 2 commits
  5. 15 Aug, 2018 2 commits
  7. 14 Aug, 2018 2 commits
  9. 07 Aug, 2018 2 commits
  11. 03 Aug, 2018 2 commits
  13. 02 Aug, 2018 6 commits
  15. 31 Jul, 2018 4 commits
  17. 30 Jul, 2018 4 commits
  19. 27 Jul, 2018 3 commits
  21. 26 Jul, 2018 1 commit
  23. 25 Jul, 2018 2 commits
  25. 11 Jul, 2018 2 commits
  27. 05 Jul, 2018 2 commits
  29. 04 Jul, 2018 5 commits
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7