Commit 148f68bf authored by Peter Müller's avatar Peter Müller Committed by Michael Tremer

location-importer: Set "is_drop" to "True" even in case of conflicts

Previously, any present override for a given network or ASN would have
caused the SQL statement not to conduct anything at all. Since "is_drop"
is the only flag being actually set here, it makes sense to do so in
case of already present overrides as well.

The effect of this is limited: Our own override files are always
considered at last, so in case of conflicts they will be the ultima
ratio. This is an intended behaviour, but slipped my mind when I filed
bug #12728, so this patch can only be seen as a partial solution - the
rest is not a bug, but a feature. :-)

Partially fixes: #12728
Signed-off-by: default avatarPeter Müller <peter.mueller@ipfire.org>
Signed-off-by: default avatarMichael Tremer <michael.tremer@ipfire.org>
parent 1714f6ee
...@@ -1320,7 +1320,7 @@ class CLI(object): ...@@ -1320,7 +1320,7 @@ class CLI(object):
source, source,
is_drop is_drop
) VALUES (%s, %s, %s) ) VALUES (%s, %s, %s)
ON CONFLICT (network) DO NOTHING""", ON CONFLICT (network) DO UPDATE SET is_drop = True""",
"%s" % network, "%s" % network,
"Spamhaus DROP lists", "Spamhaus DROP lists",
True True
...@@ -1368,7 +1368,7 @@ class CLI(object): ...@@ -1368,7 +1368,7 @@ class CLI(object):
source, source,
is_drop is_drop
) VALUES (%s, %s, %s) ) VALUES (%s, %s, %s)
ON CONFLICT (number) DO NOTHING""", ON CONFLICT (number) DO UPDATE SET is_drop = True""",
"%s" % asn, "%s" % asn,
"Spamhaus ASN-DROP list", "Spamhaus ASN-DROP list",
True True
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment