- 25 May, 2021 1 commit
-
-
Peter Müller authored
This allows us to trace back concrete changes or anomalies to their RIR source, without having to parse everything again. Further, it enables adding 3rd party sources such as IP feeds from Amazon, without loosing track of the changes introduced by them. The second version of this patchset uses ALTER TABLE to add the source columns, avoiding breaking existing SQL setups. Signed-off-by: Peter Müller <peter.mueller@ipfire.org> Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
-
- 18 May, 2021 1 commit
-
-
Peter Müller authored
Fixes: #12617 Signed-off-by: Peter Müller <peter.mueller@ipfire.org> Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
-
- 14 May, 2021 1 commit
-
-
Peter Müller authored
This reduces log spam in case of processing RIR database, checking for networks with unknown country codes assigned. If we would not have written into the database, there is no need to warn about them. Signed-off-by: Peter Müller <peter.mueller@ipfire.org> Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
-
- 06 May, 2021 2 commits
-
-
Valters Jansons authored
_location.la gets built and installed to site-packages/, however an .la file is not expected to reside in the Python root. Additionally, the dependency library listed does not have its respective .la file installed. Further complicating the situation, dh-python moves the site-packages/ files to dist-packages/ silently which then results in a broken libdir left behind in the .la file. The only reason the file is there is that it gets built inside the source directory, which gets copied entirely to location-python package as-is. Considering the situation, this commit ensures the .la files is not packaged by deleting it from the package files subdirectory. location-importer package pulls in two Python (.py) files from the source directory. These files should not be included in the location-python package as a result. Resolves: lintian: unknown-file-in-python-module-directory, incorrect-libdir-in-la-file, non-empty-dependency_libs-in-la-file, binaries-have-file-conflict Signed-off-by: Valters Jansons <valter.jansons@gmail.com> Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
-
Valters Jansons authored
New packages have been added since the inception of the .gitignore and as a result during build we see directories such as location-importer/ and files such as location-importer.debhelper.log. This commit ensures all temporary subdirectories, and additional generic build artifact files, are ignored by Git. The subdirectory exceptions to this rule are: - d/patches/ which may be used by Quilt considering the source format is '3.0 (quilt)', - d/source/ for the format file, - d/tests/ which may be used by autopkgtest to specify what test suites exist for the source. See: https://salsa.debian.org/ci-team/autopkgtest/-/raw/debian/5.16/doc/README.package-tests.rstSigned-off-by: Valters Jansons <valter.jansons@gmail.com> Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
-
- 19 Apr, 2021 6 commits
-
-
Valters Jansons authored
Systemd units are expected to provide some documentation information such as manpages, or direct links, which provide more details about that unit. This commit simply links location-update.service to the manual for location(8) followed by a fallback to the online manual. See: https://manpages.debian.org/buster/systemd/systemd.unit.5.en.html#%5BUNIT%5D_SECTION_OPTIONS Resolves: lintian: systemd-service-file-missing-documentation-key Signed-off-by: Valters Jansons <valter.jansons@gmail.com> Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
-
Valters Jansons authored
Packages defined as '3.0 (quilt)' are expected to provide information about how the latest upstream information can be obtained, as a special d/watch file. This can then get used by uscan(1). To see how the metadata is utilized, and how the network requests are made behind the scenes, you can locally run: $ uscan --no-download --verbose --debug Resolves: lintian: debian-watch-file-is-missing Signed-off-by: Valters Jansons <valter.jansons@gmail.com> Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
-
Valters Jansons authored
Due to the invocation of py3compile (via dh-python) in location-importer and location-python packages, those packages have different bytecode for varying architectures, and as a result are not 'Multi-Arch: same'. Resolves: lintian: multi-arch-same-package-calls-pycompile Signed-off-by: Valters Jansons <valter.jansons@gmail.com> Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
-
Valters Jansons authored
Resolves: lintian: package-does-not-install-examples Signed-off-by: Valters Jansons <valter.jansons@gmail.com> Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
-
Valters Jansons authored
Resolves: lintian: insecure-copyright-format-uri Signed-off-by: Valters Jansons <valter.jansons@gmail.com> Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
-
Valters Jansons authored
Resolves: lintian: wrong-section-according-to-package-name Signed-off-by: Valters Jansons <valter.jansons@gmail.com> Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
-
- 16 Apr, 2021 1 commit
-
-
Valters Jansons authored
POTFILES.in should not contain src/python/__init__.py file as it is not present in the committed tree. It has its respective .in file which is present instead. This commit further ensures po/POTFILES.in generator avoids such files that Git ignores (using git-check-ignore during find). Signed-off-by: Valters Jansons <valter.jansons@gmail.com> Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
-
- 14 Apr, 2021 2 commits
-
-
Valters Jansons authored
Rewriting history is generally considered a "not-so-good" thing, however here the historical data does not align with best practises and therefore it is beneficial to provide a better example going forward. There is only one initial release. Everything following that should list some kind of release notes or changelog, or at the very least just say something along the lines of "New version" rather than "Initial release". In this commit, the Git history is used for this task, filtering out "Makefile" changes as to retain only changes that are visible to users, excluding building tooling. For Debian packages, upon release, the target distribution should be updated to "unstable" (or "experimental" if preferred for any reason) when a release is finalized. During development, an invalid distribution name is expected to be there for tracking unreleased changes. That is why "UNRELEASED" is the standard way of specifying ongoing development, being an invalid distribution name itself. The "(Closes: #XXXXXX)" tag is intended for linking to Debian bug tracker, such as linking to the initial Intent to Package ticket, or later update/bugfix tickets. There does not appear to be a bug tracker in use for this task here, and the XXXXXX bug ticket number does not take you anywhere. It's therefore better to just remove it. Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
-
Valters Jansons authored
The email address information should be inside brackets. This commit ensures the missing bracket character issue is remedied. Reviewed-by: Peter Müller <peter.mueller@ipfire.org> Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
-
- 07 Apr, 2021 1 commit
-
-
Valters Jansons authored
Debian has automated building tools that handle source trees directly. It is expected that you can pick up a source tarball, and with the appropriate debian/ subtree, a successful build can be produced using the `debuild` tool. This depends on all the build steps having been included as part of the debian/rules file (see: `man debuild`). This commit ensures there is no need to manually run autogen.sh on a locally extracted source tarball prior to building for Debian. This is accomplished by adding the `intltoolize` command to the override_dh_auto_configure step in d/rules. There is no need to add the `autoreconf` command due to dh-autoreconf always handling that prior to the dh_auto_configure step. Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
-
- 31 Mar, 2021 3 commits
-
-
Michael Tremer authored
Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
-
Michael Tremer authored
This reverts commit d39d928b. Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
-
Peter Müller authored
There is no sense in parsing and storting networks whose country codes cannot be found in the ISO-3166-x country code table. This avoids side effects in applications using the location database, and introduces another sanity check to compensate bogus RIR data. On location02, this affects some networks from APNIC (country code: ZZ) as well as a bunch of smaller allocations within the RIPE region still tagged to CS or YU (Yugoslavia). To my surprise, no network tagged as SU (Soviet Union) was found - while the NIC for .su TLD is still operational. :-) Applying this patch causes the countries to be processed before update_whois() is called. In case no countries are present in the SQL table, this check is silently omitted. Fixes: #12510 Signed-off-by: Peter Müller <peter.mueller@ipfire.org> Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
-
- 29 Mar, 2021 1 commit
-
-
Peter Müller authored
The IP range given in an inetnum object apparently not necessarily matches distinct subnet boundaries. As a result, the current attempt to calculate its CIDR mask resulted in faulty subnets not covering the entire IP range. This patch leaves the task of enumerating subnets to the ipaddress module itself, which handles things much more robust. Since the output may contain of several subnets, a list for the inetnum key is necessary as well as a loop over them when conducting the SQL statements. Fixes: #12595 Cc: Michael Tremer <michael.tremer@ipfire.org> Signed-off-by: Peter Müller <peter.mueller@ipfire.org> Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
-
- 22 Mar, 2021 1 commit
-
-
Michael Tremer authored
This was a potential memory leak. Reported-by: Gisle Vanem <gisle.vanem@gmail.com> Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
-
- 02 Mar, 2021 1 commit
-
-
Stefan Schantl authored
Signed-off-by: Stefan Schantl <stefan.schantl@ipfire.org> Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
-
- 26 Feb, 2021 1 commit
-
-
Stefan Schantl authored
Specifing the CC and LD flags is not required because perl MakeMaker takes care of this. Fixes #12574. Signed-off-by: Stefan Schantl <stefan.schantl@ipfire.org> Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
-
- 23 Feb, 2021 1 commit
-
-
Stefan Schantl authored
This caused to gain the following error when building: Only one of PREFIX or INSTALL_BASE can be given. Not both. Using INSTALLDIRS=vendor is the common way to get the modules installed into the right directories. Fixes #12573. Signed-off-by: Stefan Schantl <stefan.schantl@ipfire.org> Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
-
- 25 Jan, 2021 2 commits
-
-
Peter Müller authored
These are nothing to worry about, which is why debug log facility is more suitable here than informational or warning. Signed-off-by: Peter Müller <peter.mueller@ipfire.org> Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
-
Peter Müller authored
2002::/16 is an anycast prefix for 6to4 scenarios, as specified in RFC 3068. We currently process an announcement from Hurricane Electric for it, and since it is an anycast network, multiple entities across the world announce it as well. Thereof, it does not make sense to include it in the database - as of today, we do not have a country for it, either. Signed-off-by: Peter Müller <peter.mueller@ipfire.org> Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
-
- 23 Dec, 2020 1 commit
-
-
Peter Müller authored
Fixes: #12549 Signed-off-by: Peter Müller <peter.mueller@ipfire.org> Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
-
- 21 Dec, 2020 1 commit
-
-
Michael Tremer authored
Fixes: #12554 Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
-
- 02 Dec, 2020 1 commit
-
-
Michael Tremer authored
Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
-
- 01 Dec, 2020 1 commit
-
-
Michael Tremer authored
We used to simply take the first element from the stack after we have split a network. That is wrong because it is not passing through any filters and no further subnet checks. It could have therefore been that the tree was not entirely flat. Reported-by: Arne Fitzenreiter <arne_f@ipfire.org> Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
-
- 27 Nov, 2020 5 commits
-
-
Michael Tremer authored
Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
-
Michael Tremer authored
This cannot happen and generated a compiler warning Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
-
Michael Tremer authored
Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
-
Michael Tremer authored
Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
-
Michael Tremer authored
Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
-
- 26 Nov, 2020 4 commits
-
-
Michael Tremer authored
Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
-
Michael Tremer authored
The list was otherwise not sorted Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
-
Michael Tremer authored
Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
-
Michael Tremer authored
Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
-
- 25 Nov, 2020 2 commits
-
-
Michael Tremer authored
Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
-
Michael Tremer authored
Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
-