- 02 Sep, 2021 3 commits
-
-
Michael Tremer authored
Signed-off-by:Michael Tremer <michael.tremer@ipfire.org>
-
Michael Tremer authored
Signed-off-by: -
Michael Tremer authored
These are used in multiple places, but there is no good place where those should go, yet. To make them usable in more places, I am temporarily moving them here. Signed-off-by:
-
- 11 Aug, 2021 1 commit
-
-
Peter Müller authored
This one apparently went down the drain between these two patches: - https://patchwork.ipfire.org/project/location/patch/20210522125758.28770-1-peter.mueller@ipfire.org/ - https://patchwork.ipfire.org/project/location/patch/aefd1904-4b38-f5cf-ab1d-9d69636cf914@ipfire.org/ Due to other safeguards, the current damage in production is limited to: location=# SELECT * FROM networks WHERE country = 'ZZ'; network | country | original_countries | source --------------------+---------+--------------------+-------- 130.195.64.0/19 | ZZ | {ZZ} | APNIC 130.195.96.0/19 | ZZ | {ZZ} | APNIC 122.252.24.0/21 | ZZ | {ZZ} | APNIC 2406:840:10::/48 | ZZ | {ZZ} | APNIC 2406:840:fd0f::/48 | ZZ | {ZZ} | APNIC (5 rows) Fixes: #12673 Signed-off-by:
Peter Müller <peter.mueller@ipfire.org> Signed-off-by:
-
- 20 Jul, 2021 1 commit
-
-
Peter Müller authored
A decent amount of autnum objects - especially, but not exclusively in the APNIC sector - does not contain a link to an organisation handle. In such cases, this patch is going to use the first description line of the atunum object in question (if available) as a string for its name. The overwhelming majority of affected ASNs contains a valuable information there, so this is almost as good as having an organisation handle linked to it. Fixes: #12660 Signed-off-by:
-
- 14 Jul, 2021 1 commit
-
-
Valters Jansons authored
- Update for maintainer name and email address, as to reflect who actually prepared this release of the package. It was not me, but I was selected due to having the first commit on the package. To mitigate against this, when running the `debchange --release` (`dch -r`) command, environment variables DEBFULLNAME and DEBEMAIL should be configured properly for the current user. - Removal of NMU comment on my name, as I am not really doing a non-maintainer upload. I would say the 'NMU' message is fairly useless on this repository, as it is self-maintained here. Signed-off-by:
Valters Jansons <valter.jansons@gmail.com> Signed-off-by:
-
- 11 Jul, 2021 6 commits
-
-
Michael Tremer authored
Signed-off-by: -
Michael Tremer authored
Signed-off-by: -
Michael Tremer authored
Signed-off-by: -
Michael Tremer authored
This is what we do when we initialize the stringpool Signed-off-by: -
Michael Tremer authored
Signed-off-by: -
Michael Tremer authored
Signed-off-by:
-
- 09 Jul, 2021 2 commits
-
-
Michael Tremer authored
Signed-off-by: -
Michael Tremer authored
Signed-off-by:
-
- 20 Jun, 2021 2 commits
-
-
Valters Jansons authored
This commit further builds on historical changelog modifications, to properly attribute all authors of the commits. An additional d/genchangelog.sh script has been added. This allows generation of changelog entries, internally using `debchange` (`dch`). The script accepts an argument, which is the commit range to generate entries for. Each commit's subject line (first line of body) is used, along with author name and email. This information is added to the changelog. Automatic detection (via `debchange` built-in functionality) is used to determine whether these entries should be added to an existing version number. If there is no UNRELEASED version, then a new version is automatically tagged. The new version tag will usually need to be modified, for example, replacing an automatically generated 0.9.6-2 with 0.9.7-1. The final release change (s/UNRELEASED/unstable/) needs to be done manually as well, when the Git tag is actually being tagged. `dch -r` can be useful for this particular purpose. Signed-off-by:
-
Peter Müller authored
location-import.in: optimise regular expression for filtering ASN allocations to other RIRs when parsing ARIN AS names file https://lists.ipfire.org/pipermail/location/2021-June/000394.htmlReported-by:
-
- 11 Jun, 2021 1 commit
-
-
Valters Jansons authored
There are muiltiple standards of listing symbols throughout the Linux ecosystem. For `dpkg`, a d/package.symbols file tracks symbols, and in which version they were added in. This is then used to allow dependency checks/resolution. See man:dpkg-gensymbols(1) for details about the generation, and man:dpkg-shlibdeps(1) for how the symbols file ends up being used. This commit adds a d/libloc1.symbols file, containing the current state of the symbols. There is now also a d/gensymbols.sh script, which generates this symbols file. The script tries to determine what Git tags need to be checked for changes in symbols, by looking at current maximum version referenced in symbols file. After checking tags, the current revision is also processed, to allow building symbols file for a yet unreleased version (prior to tagging it). This is to allow symbols changes to be included in a tag. Do keep in mind, that for the workflow above, when running the script, the d/changelog file should contain information about what version the current revision will be released at (potentially tagged as UNRELEASED in the d/changelog file). Otherwise, if there is no version tagged, the `dpkg-gensymbols` tool will use the old version information, in turn incorrectly attributing new symbols to an old version. Signed-off-by:
-
- 10 Jun, 2021 4 commits
-
-
Michael Tremer authored
When an invalid country code is entered, loc_country_new returns an error which is interpreted as a match to the list since we check for a non-zero return code. Any invalid country codes are now silently ignored and not considered a match. Fixes: #12620 - "location list-networks-by-cc" returns garbage Signed-off-by: -
Peter Müller authored
Amazon publishes information regarding some of their IP networks primarily used for AWS cloud services in a machine-readable format. To improve libloc lookup results for these, we have little choice other than importing and parsing them. Unfortunately, there seems to be no machine-readable list of the locations of their data centers or availability zones available. If there _is_ any, please let the author know. The second version of this patch adds a meaningful description for the "source" column in the overrides tables, to make introduced changes less intransparent. Fixes: #12594 Signed-off-by:
-
Peter Müller authored
This allows us to track changes introduced by IP feeds from 3rd parties, such as Amazon AWS, on the SQL server side. In order not to break existing tables (which would required TRUNCATE), there currently is no constraint set for the new column, but "NOT NULL" is planned in the future. Signed-off-by:
-
Peter Müller authored
ARIN and LACNIC, unfortunately, do not seem to publish data containing human readable AS names. For the former, we at least have a list of tecnical names, which this patch fetches and inserts into the autnums table. While some of them do not seem to be suitable for human consumption (i. e. being very cryptic), providing these data might be helpful neverthelesss. The second version of this patch contains some additional remarks on efficient Python coding style from Michael, doing things more "pythonic". Signed-off-by:
-
- 07 Jun, 2021 3 commits
-
-
Peter Müller authored
This patch implements an additional flag intended for networks and Autonomous Systems being considered hostile. While libloc does not and should not be an opinionated database, reality shows it is being used this way. Hereby, we assign "XD" (drop) as a custom country code for networks being flagged this way. According to ISO, "XA" to "XZ" are reserved for "user-assgined codes" (https://www.iso.org/glossary-for-iso-3166.html), so this is a safe thing to do. This patch does not interfere with "A1" to "A3", which we currently assign outside standardised country code ranges for historical reasons. Neither does it specify any policy or source for tagging networks with a "drop" flag. Doing so is beyond the scope of this - technical - approach. To avoid confusions with the SQL "DROP" command, "is_drop" will be used as a column name for database operations. Thanks to Michael for his remarks and ideas during the run-up. Cc: Michael Tremer <michael.tremer@ipfire.org> Signed-off-by:
-
Peter Müller authored
https://lists.ipfire.org/pipermail/location/2021-May/000377.htmlReported-by:
-
Peter Müller authored
This helps us to determine how many network objects have more than one country set, and what their original country code set looked like. The third version of this patch uses ALTER TABLE to add the column for original countries, preventing existing SQL setups from breaking, and is correctly based against the current "master" branch. Signed-off-by:
-
- 25 May, 2021 2 commits
-
-
Peter Müller authored
Signed-off-by:
-
Peter Müller authored
This allows us to trace back concrete changes or anomalies to their RIR source, without having to parse everything again. Further, it enables adding 3rd party sources such as IP feeds from Amazon, without loosing track of the changes introduced by them. The second version of this patchset uses ALTER TABLE to add the source columns, avoiding breaking existing SQL setups. Signed-off-by:
-
- 18 May, 2021 1 commit
-
-
Peter Müller authored
Fixes: #12617 Signed-off-by:
-
- 14 May, 2021 1 commit
-
-
Peter Müller authored
This reduces log spam in case of processing RIR database, checking for networks with unknown country codes assigned. If we would not have written into the database, there is no need to warn about them. Signed-off-by:
-
- 06 May, 2021 2 commits
-
-
Valters Jansons authored
_location.la gets built and installed to site-packages/, however an .la file is not expected to reside in the Python root. Additionally, the dependency library listed does not have its respective .la file installed. Further complicating the situation, dh-python moves the site-packages/ files to dist-packages/ silently which then results in a broken libdir left behind in the .la file. The only reason the file is there is that it gets built inside the source directory, which gets copied entirely to location-python package as-is. Considering the situation, this commit ensures the .la files is not packaged by deleting it from the package files subdirectory. location-importer package pulls in two Python (.py) files from the source directory. These files should not be included in the location-python package as a result. Resolves: lintian: unknown-file-in-python-module-directory, incorrect-libdir-in-la-file, non-empty-dependency_libs-in-la-file, binaries-have-file-conflict Signed-off-by:
-
Valters Jansons authored
New packages have been added since the inception of the .gitignore and as a result during build we see directories such as location-importer/ and files such as location-importer.debhelper.log. This commit ensures all temporary subdirectories, and additional generic build artifact files, are ignored by Git. The subdirectory exceptions to this rule are: - d/patches/ which may be used by Quilt considering the source format is '3.0 (quilt)', - d/source/ for the format file, - d/tests/ which may be used by autopkgtest to specify what test suites exist for the source. See: https://salsa.debian.org/ci-team/autopkgtest/-/raw/debian/5.16/doc/README.package-tests.rstSigned-off-by:
-
- 19 Apr, 2021 6 commits
-
-
Valters Jansons authored
Systemd units are expected to provide some documentation information such as manpages, or direct links, which provide more details about that unit. This commit simply links location-update.service to the manual for location(8) followed by a fallback to the online manual. See: https://manpages.debian.org/buster/systemd/systemd.unit.5.en.html#%5BUNIT%5D_SECTION_OPTIONS Resolves: lintian: systemd-service-file-missing-documentation-key Signed-off-by:
-
Valters Jansons authored
Packages defined as '3.0 (quilt)' are expected to provide information about how the latest upstream information can be obtained, as a special d/watch file. This can then get used by uscan(1). To see how the metadata is utilized, and how the network requests are made behind the scenes, you can locally run: $ uscan --no-download --verbose --debug Resolves: lintian: debian-watch-file-is-missing Signed-off-by:
-
Valters Jansons authored
Due to the invocation of py3compile (via dh-python) in location-importer and location-python packages, those packages have different bytecode for varying architectures, and as a result are not 'Multi-Arch: same'. Resolves: lintian: multi-arch-same-package-calls-pycompile Signed-off-by:
-
Valters Jansons authored
Resolves: lintian: package-does-not-install-examples Signed-off-by:
-
Valters Jansons authored
Resolves: lintian: insecure-copyright-format-uri Signed-off-by:
-
Valters Jansons authored
Resolves: lintian: wrong-section-according-to-package-name Signed-off-by:
-
- 16 Apr, 2021 1 commit
-
-
Valters Jansons authored
POTFILES.in should not contain src/python/__init__.py file as it is not present in the committed tree. It has its respective .in file which is present instead. This commit further ensures po/POTFILES.in generator avoids such files that Git ignores (using git-check-ignore during find). Signed-off-by:
-
- 14 Apr, 2021 2 commits
-
-
Valters Jansons authored
Rewriting history is generally considered a "not-so-good" thing, however here the historical data does not align with best practises and therefore it is beneficial to provide a better example going forward. There is only one initial release. Everything following that should list some kind of release notes or changelog, or at the very least just say something along the lines of "New version" rather than "Initial release". In this commit, the Git history is used for this task, filtering out "Makefile" changes as to retain only changes that are visible to users, excluding building tooling. For Debian packages, upon release, the target distribution should be updated to "unstable" (or "experimental" if preferred for any reason) when a release is finalized. During development, an invalid distribution name is expected to be there for tracking unreleased changes. That is why "UNRELEASED" is the standard way of specifying ongoing development, being an invalid distribution name itself. The "(Closes: #XXXXXX)" tag is intended for linking to Debian bug tracker, such as linking to the initial Intent to Package ticket, or later update/bugfix tickets. There does not appear to be a bug tracker in use for this task here, and the XXXXXX bug ticket number does not take you anywhere. It's therefore better to just remove it. Signed-off-by: -
Valters Jansons authored
The email address information should be inside brackets. This commit ensures the missing bracket character issue is remedied. Reviewed-by:
-
- 07 Apr, 2021 1 commit
-
-
Valters Jansons authored
Debian has automated building tools that handle source trees directly. It is expected that you can pick up a source tarball, and with the appropriate debian/ subtree, a successful build can be produced using the `debuild` tool. This depends on all the build steps having been included as part of the debian/rules file (see: `man debuild`). This commit ensures there is no need to manually run autogen.sh on a locally extracted source tarball prior to building for Debian. This is accomplished by adding the `intltoolize` command to the override_dh_auto_configure step in d/rules. There is no need to add the `autoreconf` command due to dh-autoreconf always handling that prior to the dh_auto_configure step. Signed-off-by:
-
