• Jiri Benc's avatar
    gre: remove superfluous pskb_may_pull · 00b20340
    Jiri Benc authored
    The call to gre_parse_header is either followed by iptunnel_pull_header, or
    in the case of ICMP error path, the actual header is not accessed at all.
    
    In the first case, iptunnel_pull_header will call pskb_may_pull anyway and
    it's pointless to do it twice. The only difference is what call will fail
    with what error code but the net effect is still the same in all call sites.
    
    In the second case, pskb_may_pull is pointless, as skb->data is at the outer
    IP header and not at the GRE header.
    Signed-off-by: default avatarJiri Benc <jbenc@redhat.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    00b20340
gre_demux.c 4.27 KB