• Lars-Peter Clausen's avatar
    ext3: Fix format string issues · 058f677c
    Lars-Peter Clausen authored
    commit 8d0c2d10 upstream.
    
    ext3_msg() takes the printk prefix as the second parameter and the
    format string as the third parameter. Two callers of ext3_msg omit the
    prefix and pass the format string as the second parameter and the first
    parameter to the format string as the third parameter. In both cases
    this string comes from an arbitrary source. Which means the string may
    contain format string characters, which will
    lead to undefined and potentially harmful behavior.
    
    The issue was introduced in commit 4cf46b67("ext3: Unify log messages
    in ext3") and is fixed by this patch.
    Signed-off-by: default avatarLars-Peter Clausen <lars@metafoo.de>
    Signed-off-by: default avatarJan Kara <jack@suse.cz>
    Signed-off-by: default avatarBen Hutchings <ben@decadent.org.uk>
    058f677c
super.c 83.8 KB