• Anton Vorontsov's avatar
    fsl_diu_fb: fix build with CONFIG_PM=y, plus fix some warnings · 05946bce
    Anton Vorontsov authored
    This patch fixes following build error when CONFIG_PM is set.
    
      CC      drivers/video/fsl-diu-fb.o
    drivers/video/fsl-diu-fb.c: In function 'fsl_diu_suspend':
    drivers/video/fsl-diu-fb.c:1327: error: 'ofdev' undeclared (first use in this function)
    drivers/video/fsl-diu-fb.c:1327: error: (Each undeclared identifier is reported only once
    drivers/video/fsl-diu-fb.c:1327: error: for each function it appears in.)
    drivers/video/fsl-diu-fb.c: In function 'fsl_diu_resume':
    drivers/video/fsl-diu-fb.c:1337: error: 'ofdev' undeclared (first use in this function)
    
    While I'm at it, also fix this warning:
    
    drivers/video/fsl-diu-fb.c: In function 'fsl_diu_alloc':
    drivers/video/fsl-diu-fb.c:314: warning: format '%lx' expects type 'long unsigned int', but argument 3 has type 'phys_addr_t'
    
    And these section mismatches:
    
    ..from the function fsl_diu_remove() to the function .exit.text:uninstall_fb()
    ..from the function fsl_diu_remove() to the function .exit.text:uninstall_fb()
    ..from the function install_fb() to the variable .devinit.data:fsl_diu_mode_db
    ..from the function install_fb() to the variable .devinit.data:fsl_diu_mode_db
    ..from the function fsl_diu_probe() to the function .exit.text:uninstall_fb()
    ..from the function fsl_diu_probe() to the function .exit.text:uninstall_fb()
    
    Also, some sparse fixes: make two functions static, and use NULL where
    appropriate. There are still a lot of sparse warnings, mainly wrt absence
    of __iomem annotations, but some will require ugly __force stuff. I'll leave
    them for now, since proper fix would be not that trivial as few one-liners
    below.
    Signed-off-by: default avatarAnton Vorontsov <avorontsov@ru.mvista.com>
    Cc: Timur Tabi <timur@freescale.com>
    Cc: Antonino Daplas <adaplas@gmail.com>
    Cc: York Sun <yorksun@freescale.com>
    Cc: Krzysztof Helt <krzysztof.h1@poczta.fm>
    Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
    Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
    05946bce
fsl-diu-fb.c 43.8 KB