• Takashi Sakamoto's avatar
    ALSA: firewire-tascam: accessing to user space outside spinlock · 04b2d9c9
    Takashi Sakamoto authored
    In hwdep interface of firewire-tascam driver, accessing to user space is
    in a critical section with disabled local interrupt. Depending on
    architecture, accessing to user space can cause page fault exception. Then
    local processor stores machine status and handle the synchronous event. A
    handler corresponding to the event can call task scheduler to wait for
    preparing pages. In a case of usage of single core processor, the state to
    disable local interrupt is worse because it doesn't handle usual interrupts
    from hardware.
    
    This commit fixes this bug, by performing the accessing outside spinlock.
    Reported-by: default avatarVaishali Thakkar <vaishali.thakkar@oracle.com>
    Cc: stable@vger.kernel.org
    Fixes: e5e0c3dd('ALSA: firewire-tascam: add hwdep interface')
    Signed-off-by: default avatarTakashi Sakamoto <o-takashi@sakamocchi.jp>
    Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
    04b2d9c9
tascam-hwdep.c 4 KB