• Arnd Bergmann's avatar
    Input: msm-vibrator - use correct gpio header · 741c73ed
    Arnd Bergmann authored
    When CONFIG_GPIOLIB is not set, we get a couple of build
    errors during test building:
    
    drivers/input/misc/msm-vibrator.c: In function 'msm_vibrator_start':
    drivers/input/misc/msm-vibrator.c:79:3: error: implicit declaration of function 'gpiod_set_value_cansleep'; did you mean 'gpio_set_value_cansleep'? [-Werror=implicit-function-declaration]
       gpiod_set_value_cansleep(vibrator->enable_gpio, 1);
       ^~~~~~~~~~~~~~~~~~~~~~~~
       gpio_set_value_cansleep
    drivers/input/misc/msm-vibrator.c: In function 'msm_vibrator_probe':
    drivers/input/misc/msm-vibrator.c:176:26: error: implicit declaration of function 'devm_gpiod_get'; did you mean 'devm_gpio_free'? [-Werror=implicit-function-declaration]
      vibrator->enable_gpio = devm_gpiod_get(&pdev->dev, "enable",
                              ^~~~~~~~~~~~~~
                              devm_gpio_free
    drivers/input/misc/msm-vibrator.c:177:13: error: 'GPIOD_OUT_LOW' undeclared (first use in this function); did you mean 'GPIOF_INIT_LOW'?
                 GPIOD_OUT_LOW);
                 ^~~~~~~~~~~~~
                 GPIOF_INIT_LOW
    drivers/input/misc/msm-vibrator.c:177:13: note: each undeclared identifier is reported only once for each function it appears in
    
    This is easy to avoid when we use gpio/consumer.h as the documented interface.
    
    Fixes: 0f681d09 ("Input: add new vibrator driver for various MSM SOCs")
    Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
    Reviewed-by: default avatarLinus Walleij <linus.walleij@linaro.org>
    Signed-off-by: default avatarDmitry Torokhov <dmitry.torokhov@gmail.com>
    741c73ed
msm-vibrator.c 6.93 KB