• Adam Jackson's avatar
    drm/i915: Use spatio-temporal dithering on PCH · 0a31a448
    Adam Jackson authored
    Spatial dither is better than nothing, but ST is even better.
    
    (from ajax's followup message:)
      I noticed this with:
    
      http://ajax.fedorapeople.org/YellowFlower.jpg
    
      set as my desktop background in Gnome on a 1280x800 machine (in
      particular, a Sony Vaio VPCB1 with 6-bit panel and a rather bright black
      level).  Easiest way to test this is by poking at PIPEACONF with
      intel_reg_write directly:
    
      % sudo intel_reg_write 0x70008 0xc0000040 # no dither
      % sudo intel_reg_write 0x70008 0xc0000050 # spatial
      % sudo intel_reg_write 0x70008 0xc0000054 # ST
    
      I notice it especially strongly in the relatively flat dark area in the
      top left.  Closer than about 18" I can see a noticeable checkerboard
      pattern with plain spatial dithering.  ST smooths that out; I can still
      tell that it's lacking color precision, but it's not offensive.
    Signed-off-by: default avatarAdam Jackson <ajax@redhat.com>
    Signed-off-by: default avatarEric Anholt <eric@anholt.net>
    0a31a448
i915_reg.h 95.9 KB