• Tony Battersby's avatar
    scsi: fix memory leak with scsi-mq · 0c958ecc
    Tony Battersby authored
    Fix a memory leak with scsi-mq triggered by commands with large data
    transfer length.
    
    __sg_alloc_table() sets both table->nents and table->orig_nents to the
    same value.  When the scatterlist is DMA-mapped, table->nents is
    overwritten with the (possibly smaller) size of the DMA-mapped
    scatterlist, while table->orig_nents retains the original size of the
    allocated scatterlist.  scsi_free_sgtable() should therefore check
    orig_nents instead of nents, and all code that initializes sdb->table
    without calling __sg_alloc_table() should set both nents and orig_nents.
    
    Fixes: d285203c ("scsi: add support for a blk-mq based I/O path.")
    Cc: <stable@vger.kernel.org> # 3.17+
    Signed-off-by: default avatarTony Battersby <tonyb@cybernetics.com>
    Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
    Reviewed-by: default avatarEwan D. Milne <emilne@redhat.com>
    Signed-off-by: default avatarJames Bottomley <JBottomley@Odin.com>
    0c958ecc
scsi_error.c 69.9 KB