• Stephane Eranian's avatar
    perf/x86: Fix uninitialized pt_regs in intel_pmu_drain_bts_buffer() · 0e48026a
    Stephane Eranian authored
    This patch fixes an uninitialized pt_regs struct in drain BTS
    function. The pt_regs struct is propagated all the way to the
    code_get_segment() function from perf_instruction_pointer()
    and may get garbage.
    
    We cannot simply inherit the actual pt_regs from the interrupt
    because BTS must be flushed on context-switch or when the
    associated event is disabled. And there we do not have a pt_regs
    handy.
    
    Setting pt_regs to all zeroes may not be the best option but it
    is not clear what else to do given where the drain_bts_buffer()
    is called from.
    
    In V2, we move the memset() later in the code to avoid doing it
    when we end up returning early without doing the actual BTS
    processing. Also dropped the reg.val initialization because it
    is redundant with the memset() as suggested by PeterZ.
    Signed-off-by: default avatarStephane Eranian <eranian@google.com>
    Acked-by: default avatarPeter Zijlstra <a.p.zijlstra@chello.nl>
    Cc: peterz@infradead.org
    Cc: sqazi@google.com
    Cc: ak@linux.intel.com
    Cc: jolsa@redhat.com
    Link: http://lkml.kernel.org/r/20130319151038.GA25439@quadSigned-off-by: default avatarIngo Molnar <mingo@kernel.org>
    0e48026a
perf_event_intel_ds.c 17.4 KB