• Mike Snitzer's avatar
    block: eliminate potential for infinite loop in blkdev_issue_discard · 0f799603
    Mike Snitzer authored
    Due to the recently identified overflow in read_capacity_16() it was
    possible for max_discard_sectors to be zero but still have discards
    enabled on the associated device's queue.
    
    Eliminate the possibility for blkdev_issue_discard to infinitely loop.
    
    Interestingly this issue wasn't identified until a device, whose
    discard_granularity was 0 due to read_capacity_16 overflow, was consumed
    by blk_stack_limits() to construct limits for a higher-level DM
    multipath device.  The multipath device's resulting limits never had the
    discard limits stacked because blk_stack_limits() will only do so if
    the bottom device's discard_granularity != 0.  This resulted in the
    multipath device's limits.max_discard_sectors being 0.
    Signed-off-by: default avatarMike Snitzer <snitzer@redhat.com>
    Signed-off-by: default avatarJens Axboe <jaxboe@fusionio.com>
    0f799603
blk-lib.c 3.94 KB