• Jan Engelhardt's avatar
    fs/fat/: refine chmod checks · 19c561a6
    Jan Engelhardt authored
    Prohibit mode changes in non-quiet mode that cannot be stored reliably with
    the on-disk format.
    
    Suppose a vfat filesystem is mounted with umask=0 and [not-quiet].  Then
    all files will have mode 0777.  Trying to change the owner will fail,
    because fat does not know about owners or groups.  chmod 0770, on the other
    hand, will succeed, even though fat does not know about the permission
    triplet [user/group/other].
    
    So this patch changes fat's not-quiet behavior so that only UNIX modes are
    accepted that can be mapped lossless between the fat disk format and the
    local system.  There is only one attribute, and that is the readonly
    attribute, which is mapped to the UNIX write permission bit(s).  chmod 0555
    is therefore valid (taking away the +w bits <=> setting the readonly
    attribute).  Since chmod 0775 and chmod 0755 is an ambiguous case as to
    whether to set or clear the readonly bit, these modes are also denied.
    
    In quiet mode, chmod and chown will continue to "succeed" as they did
    before, meaning that a subsequent stat() will temporarily return the new
    mode as long as the inode is not reread from disk, and chown will silently
    do nothing, not even return the new uid/gid in stat().
    Signed-off-by: default avatarJan Engelhardt <jengelh@computergmbh.de>
    Cc: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
    Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
    Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
    19c561a6
file.c 8.37 KB