• Linus Walleij's avatar
    pinctrl: sirf/atlas7: stop poking around in GPIO internals · 4e6fd26d
    Linus Walleij authored
    This code is poking around in the gpio_chip:s internal structures
    to achieve some kind of pin to GPIO mappings.
    
    - It is wrong to poke around in these structs and the pinctrl
      maintainer was stupid to let it pass unnoticed, mea culpa.
    
    - The right interface to use is gpiochip_add_pin_range()
    
    - The code appears unused: the pin control part of the driver
      is not adding any ranges, so we're iterating over an empty
      list. Maybe it is poking around in some other pin controllers
      GPIO ranges, and that's just totally wrong, again use
      gpiochip_add_pin_range() and specify the right pin
      controller.
    
    Cc: Barry Song <baohua@kernel.org>
    Cc: Guoying Zhang <Guoying.Zhang@csr.com>
    Cc: Wei Chen <Wei.Chen@csr.com>
    Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
    4e6fd26d
pinctrl-atlas7.c 198 KB