• Nicholas Kazlauskas's avatar
    drm/amd/display: Make BREAK_TO_DEBUGGER() a debug print · 1aad7078
    Nicholas Kazlauskas authored
    [Why]
    Warnings in the kernel are generally treated as errors.
    
    The BREAK_TO_DEBUGGER macro is not a critical error or warning, but
    rather intended for developer use to help investigate behavior and
    sequences for other issues.
    
    We do still make use of DC_ERROR/ASSERT(0) in various places in the
    code for things that are genuine issues.
    
    Since most developers don't actually KGDB while debugging the kernel
    these essentially would have no value on their own since the KGDB
    breakpoint wouldn't trigger - ASSERT(0) was used as a shortcut to get
    a stacktrace.
    
    [How]
    Turn it into a DRM_DEBUG_DRIVER print instead. We unfortunately lose
    the stacktrace, but we still do retain some of the useful debug
    information this offers by having at least the function and line
    number loggable.
    
    If KGDB is supported in the kernel this will still trigger a real
    breakpoint as well.
    
    Cc: Harry Wentland <harry.wentland@amd.com>
    Cc: Leo Li <sunpeng.li@amd.com>
    Cc: Bhawanpreet Lakha <Bhawanpreet.Lakha@amd.com>
    Cc: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
    Signed-off-by: default avatarNicholas Kazlauskas <nicholas.kazlauskas@amd.com>
    Reviewed-by: default avatarHarry Wentland <harry.wentland@amd.com>
    Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
    1aad7078
os_types.h 3.42 KB