• Jeff Garzik's avatar
    Revert "pata_sis: Implement MWDMA for the UDMA 133 capable chips" · 1b52f2a4
    Jeff Garzik authored
    This reverts commit f20941f3.
    
    Sergei Shtylyov notes "You call min() on uncomparables [in
    mwdma_clip_to_pio()], i.e. mwdma_to_pio[] contains XFER_PIO_* and
    adev->pio_mode - XFER_PIO_0 yields you a mode number.  Thus the second
    argument will always "win" as a minimal one"
    
    Bartlomiej Zolnierkiewicz adds "There are more issues with the patch related
    to mwdma_clip_to_pio().  The function can return values between 0 and
    4 which obviously won't work well for the new code below for values
    >2 (i.e. resulting in out-of-bounds array access for the common-case
    of dev->pio_mode == XFER_PIO_4)."
    
    Bartlomiej Zolnierkiewicz also notes the patch is incomplete, failing to
    update MWDMA mode masks.
    Signed-off-by: default avatarJeff Garzik <jgarzik@redhat.com>
    1b52f2a4
pata_sis.c 22.7 KB