• Pavel Begunkov's avatar
    io_uring: fix feeding io-wq with uninit reqs · 1bcb8c5d
    Pavel Begunkov authored
    io_steal_work() can't be sure that @nxt has req->work properly set, so we
    can't pass it to io-wq as is.
    
    A dirty quick fix -- drag it through io_req_task_queue(), and always
    return NULL from io_steal_work().
    
    e.g.
    
    [   50.770161] BUG: kernel NULL pointer dereference, address: 00000000
    [   50.770164] #PF: supervisor write access in kernel mode
    [   50.770164] #PF: error_code(0x0002) - not-present page
    [   50.770168] CPU: 1 PID: 1448 Comm: io_wqe_worker-0 Tainted: G
    	I       5.8.0-rc2-00035-g2237d765-dirty #494
    [   50.770172] RIP: 0010:override_creds+0x19/0x30
    ...
    [   50.770183]  io_worker_handle_work+0x25c/0x430
    [   50.770185]  io_wqe_worker+0x2a0/0x350
    [   50.770190]  kthread+0x136/0x180
    [   50.770194]  ret_from_fork+0x22/0x30
    Signed-off-by: default avatarPavel Begunkov <asml.silence@gmail.com>
    Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
    1bcb8c5d
io_uring.c 203 KB