• Eric Dumazet's avatar
    tcp: take care of overlaps in tcp_try_coalesce() · 1ca7ee30
    Eric Dumazet authored
    Sergio Correia reported following warning :
    
    WARNING: at net/ipv4/tcp.c:1301 tcp_cleanup_rbuf+0x4f/0x110()
    
    WARN(skb && !before(tp->copied_seq, TCP_SKB_CB(skb)->end_seq),
         "cleanup rbuf bug: copied %X seq %X rcvnxt %X\n",
         tp->copied_seq, TCP_SKB_CB(skb)->end_seq, tp->rcv_nxt);
    
    It appears TCP coalescing, and more specifically commit b081f85c
    (net: implement tcp coalescing in tcp_queue_rcv()) should take care of
    possible segment overlaps in receive queue. This was properly done in
    the case of out_or_order_queue by the caller.
    
    For example, segment at tail of queue have sequence 1000-2000, and we
    add a segment with sequence 1500-2500.
    This can happen in case of retransmits.
    
    In this case, just don't do the coalescing.
    Reported-by: default avatarSergio Correia <lists@uece.net>
    Signed-off-by: default avatarEric Dumazet <edumazet@google.com>
    Tested-by: default avatarSergio Correia <lists@uece.net>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    1ca7ee30
tcp_input.c 176 KB