• Geoff Levand's avatar
    fbcon: fix workqueue shutdown · beaa4867
    Geoff Levand authored
    Add a call to cancel_work_sync() in fbcon_exit() to cancel any pending
    work in the fbcon workqueue.
    
    The current implementation of fbcon_exit() sets the fbcon workqueue
    function info->queue.func to NULL, but does not assure that there is no
    work pending when it does so.  On occasion, depending on system timing,
    there will still be pending work in the queue when fbcon_exit() is
    called.  This results in a null pointer deference when run_workqueue()
    tries to call the queue's work function.
    
    Fixes errors on shutdown similar to these:
    
      Console: switching to colour dummy device 80x25
      Unable to handle kernel paging request for data at address 0x00000000
    Signed-off-by: default avatarGeoff Levand <geoffrey.levand@am.sony.com>
    Cc: Krzysztof Helt <krzysztof.h1@poczta.fm>
    Cc: Geert Uytterhoeven <geert@linux-m68k.org>
    Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
    Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
    beaa4867
fbcon.c 87.2 KB