• J. Bruce Fields's avatar
    EXPORTFS: handle NULL returns from fh_to_dentry()/fh_to_parent() · a4f4d6df
    J. Bruce Fields authored
    While 44003728 "[PATCH] switch all filesystems over to
    d_obtain_alias" removed some cases where fh_to_dentry() and
    fh_to_parent() could return NULL, there are still a few NULL returns
    left in individual filesystems.  Thus it was a mistake for that commit
    to remove the handling of NULL returns in the callers.
    
    Revert those parts of 44003728 which removed the NULL handling.
    
    (We could, alternatively, modify all implementations to return -ESTALE
    instead of NULL, but that proves to require fixing a number of
    filesystems, and in some cases it's arguably more natural to return
    NULL.)
    
    Thanks to David for original patch and Linus, Christoph, and Hugh for
    review.
    Signed-off-by: default avatarJ. Bruce Fields <bfields@citi.umich.edu>
    Cc: David Howells <dhowells@redhat.com>
    Cc: Christoph Hellwig <hch@infradead.org>
    Cc: Hugh Dickins <hugh@veritas.com>
    Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
    a4f4d6df
expfs.c 12.2 KB